BUG/TST: Fix io.sql.write_frame replace bug and complete test coverage of if_exists functionality #4304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related to #4163 |
The if_exists argument in io.sql.write_frame needed data validation because the logic of the function implicitly used 'append' if the argument value was any string that was not either 'fail' or 'replace'. I added a new unit test to support the requirement.
This should resolve issues pandas-dev#2971 and pandas-dev#4110
This refactor results in the function logic being clearer, since if_exists is only relevant when exists is True, the program flow is better served to have if_exists control flow only when exists is True
…1d8d4 sqlite3 convenience function executescript not available in other database flavors.
|
Rebased and added test coverage for mysql flavor |
|
@hayd you have this included in SQL ? |
|
@jreback thanks, I'd missed this. Will squish and add in to legacy and sqlalchemy. |
|
@hayd just keeping it on the radar |
|
squished and rebased this branch, will see if it passes/what needs fixing. Agree this was bad, apologies on dropping the ball here. Should make sure this is also fixed in the new stuff. |
|
@jorisvandenbossche @hayd should this be incorporated / closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2971 and #4110. This also provides test coverage for the different values for the if_exists argument for io.sql.write_frame.