Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG/TST: Fix io.sql.write_frame replace bug and complete test coverage of if_exists functionality #4304

Closed
wants to merge 7 commits into from
Closed

BUG/TST: Fix io.sql.write_frame replace bug and complete test coverage of if_exists functionality #4304

wants to merge 7 commits into from

Commits on Jul 28, 2013

  1. ENH/TST: Raise error if invalid value passed to if_exists argument 

    The if_exists argument in io.sql.write_frame needed data validation
because the logic of the function implicitly used 'append' if the argument
value was any string that was not either 'fail' or 'replace'.
I added a new unit test to support the requirement.
    @davidshinn
    davidshinn committed Jul 28, 2013
    Configuration menu
    Copy the full SHA
    0c14a1a View commit details
    Browse the repository at this point in the history

  2. BUG: Fix if_exists='replace' functionality in io.sql.write_frame 

    This should resolve issues pandas-dev#2971 and pandas-dev#4110
    @davidshinn
    davidshinn committed Jul 28, 2013
    Configuration menu
    Copy the full SHA
    28f9b74 View commit details
    Browse the repository at this point in the history

  3. CLN: Refactor in between test clean ups to be more DRY

    @davidshinn
    davidshinn committed Jul 28, 2013
    Configuration menu
    Copy the full SHA
    1bc927d View commit details
    Browse the repository at this point in the history

  4. TST: Complete test coverage for if_exists uses in io.sql.write_frame

    @davidshinn
    davidshinn committed Jul 28, 2013
    Configuration menu
    Copy the full SHA
    5a2d51d View commit details
    Browse the repository at this point in the history

  5. CLN: Refactor to make interaction between exists and if_exists clearer 

    This refactor results in the function logic being clearer, since if_exists is
only relevant when exists is True, the program flow is better served to
have if_exists control flow only when exists is True
    @davidshinn
    davidshinn committed Jul 28, 2013
    Configuration menu
    Copy the full SHA
    e2f7c3a View commit details
    Browse the repository at this point in the history

  6. BUG: Fix regression introduced by c28f11a0041a9f3b25f33b0539e42fa802b… 

    …1d8d4

sqlite3 convenience function executescript not available
in other database flavors.
    @davidshinn
    davidshinn committed Jul 28, 2013
    Configuration menu
    Copy the full SHA
    5eec802 View commit details
    Browse the repository at this point in the history

  7. TST: Adding if_exist test for mysql flavor

    @davidshinn
    davidshinn committed Jul 28, 2013
    Configuration menu
    Copy the full SHA
    1f98317 View commit details
    Browse the repository at this point in the history