TST: Testing an installed package shouldn't require root permissions

[mitya57]

Trying to run nosetests3 pandas on an installed pandas package, I get:

ERROR: test_read_dta10 (pandas.io.tests.test_stata.StataTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/pandas/io/tests/test_stata.py", line 207, in test_read_dta10
    original.to_stata(path, {'datetime': 'tc'}, False)
  File "/usr/lib/python3/dist-packages/pandas/core/frame.py", line 1503, in to_stata
    writer = StataWriter(fname,self,convert_dates=convert_dates, encoding=encoding, byteorder=byteorder)
  File "/usr/lib/python3/dist-packages/pandas/io/stata.py", line 745, in __init__
    self._file = _open_file_binary_write(fname, self._encoding)
  File "/usr/lib/python3/dist-packages/pandas/io/stata.py", line 577, in _open_file_binary_write
    return open(fname, "wb")
PermissionError: [Errno 13] Permission denied: '/usr/lib/python3/dist-packages/pandas/io/tests/data/stata10.dta'

... and other similar errors. Maybe it'll be a good idea to fix the tests so that they can be run on an installed package without needing to modify the actually installed files.

[cpcloud]

If you install the package locally then you don't need root permissions. If you install with sudo then you'll need root permissions.

[cpcloud]

The tests themselves have nothing to do with the fact that they are being run as root, so it's not clear what you mean by

fix the tests so that they can be run on an installed package without needing to modify the actually installed files

see #761

[mitya57]

@cpcloud Actually I use Debian package here, installed via package manager. Also, did you really see the traceback above? The test fails because it doesn't have permission to modify a file in /usr/lib — which is related to them being run as non-root.

If I didn't convince you, this failure can also be seen on Ubuntu's Jenkins server.

[cpcloud]

Sorry, I guess I wasn't being clear. IIRC, most package managers require root permissions to install anything. Anyway, you're right. The tests should use make liberal use of the tempfile module when writing files.

[jreback]

@mitya57 I am pretty sure you are running with < 0.12. This was fixed to use a temporary (non permissioned) in 0.12.

[cpcloud]

@jreback according to this line the jenkins server above is running 0.12

+ buildtree=/tmp/tmp.KLHag020rp/dsc0-build/pandas-0.12.0~rc1+git127-gec8920a/

although not sure if that is before or after the change u mentioned

that line is near the bottom of the page

[mitya57]

Yeah, I'm using the same snapshot (ec8920a, 5-day-old), and don't see anything related in newer commits...

[jreback]

sorry....this actually specifies a direct path (which is wrong)..so yes...marking as a test bug

[jreback]

ensure_clean will generate a safe temporary file, except when a full pathname is specified (which is wrong here)