Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Breaking Changes in 3.0 (without deprecations) #44823

Open
1 of 8 tasks
jbrockmendel opened this issue Dec 8, 2021 · 7 comments
Open
1 of 8 tasks

API: Breaking Changes in 3.0 (without deprecations) #44823

jbrockmendel opened this issue Dec 8, 2021 · 7 comments
Labels
API - Consistency Internal Consistency of API/Behavior Deprecate Functionality to remove in pandas Master Tracker High level tracker for similar issues
Milestone

Comments

@jbrockmendel
Copy link
Member

jbrockmendel commented Dec 8, 2021

Discussed on today's call, this issue to discuss potential changes we may want to make in 3.0 that are too big or cumbersome to deprecate.

@jbrockmendel jbrockmendel added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Dec 8, 2021
@mroeschke mroeschke added this to the 2.0 milestone Dec 9, 2021
@lithomas1 lithomas1 added API - Consistency Internal Consistency of API/Behavior Deprecate Functionality to remove in pandas Master Tracker High level tracker for similar issues and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Dec 9, 2021
@fangchenli
Copy link
Member

fangchenli commented Dec 14, 2021

We could redo the SQL API to add compat for sqlalchemy 1.4/2.0. #40686.
#36893 is also related. We should come up with a solution to solve both issues.

To add to this. In #45660, seems like people have used the sqlite fullback class for other connection types for many years without any issue. If that is actually a popular use case, we probably should officially support it and expand our SQL tests. And this issue overlaps with #36893.

@jbrockmendel
Copy link
Member Author

@mroeschke can you confirm the axis=None box can be checked?

@mroeschke
Copy link
Member

Not completely, #50593 did not add axis=None for sum, prod, var, std, sem

@mroeschke
Copy link
Member

@jbrockmendel should we push this as breaking changes for 3.0 without deprecations or should we just start a new issue when we're toward the end of the 2.0 cycle?

@jbrockmendel
Copy link
Member Author

im fine re-purposing this

@mroeschke mroeschke modified the milestones: 2.0, 3.0 Feb 8, 2023
@mroeschke mroeschke changed the title API: Breaking Changes in 2.0 (without deprecations) API: Breaking Changes in 3.0 (without deprecations) Feb 8, 2023
@jbrockmendel
Copy link
Member Author

think the axis=None one is still viable to get for 2.0?

@mroeschke
Copy link
Member

Could be possible. I think the ones not addressed take slightly different code paths so not sure if supporting that is straightforward.

IMO it should be not blocking for 2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API - Consistency Internal Consistency of API/Behavior Deprecate Functionality to remove in pandas Master Tracker High level tracker for similar issues
Projects
None yet
Development

No branches or pull requests

4 participants