-
-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RLS: 2.0 #46776
Comments
There are currently 91 issues labeled deprecate https://github.com/pandas-dev/pandas/issues?q=is%3Aopen+is%3Aissue+label%3ADeprecate, so need to start whittling this list down. |
A few things on my radar screen that I think need to change in 2.0, which in many cases means deprecating in 1.5: |
My interpretation is that issues labeled |
Agreed @mroeschke. I've been tagging deprecation issues where the conversation makes it clear there is no consensus as "Needs Discussion". There are currently only 46 issues that are tagged deprecation but not needs discussion. Maybe it'd be reasonable to whittle down this list by either (a) implementing or (b) tagging as needs discussion. |
@pandas-dev/pandas-core Are there any objections for the next release to be 2.0? |
I think the agreement on the august call was to wait with the final decision till 1.5.1 is out in case anything unexpected happens |
As mentioned by @lithomas1 on Slack, do folks think we should push a |
I updated this issue description with the list of blockers for 2.0 I'm aware of (the known deprecations, plus a 1.4 deprecation that was not track or enforced). If there are other blockers to be considered, it'd be good to add them to the list before the call next week, so we can discuss them. |
Updated the issue description after the outcome of the 2023-01-11 dev meeting (only blocker was the Int/Uint/FloatIndex removal) |
Updated the issue description after the outcome of the 2023-02-08 dev meeting @datapythonista would you still be willing to do a 2.0rc release sometime next week assuming the above PRs get merged? @lithomas1 expressed willingness to do a release if you are unable |
Sorry, I have a conflict, and I'm teaching at the time of the pandas dev call, I won't be able to join them for at least couple of months. But I can do the release when things are ready, and also happy to hand over to @lithomas1 if he prefers to do them. But if needed, no problem to continue doing the releases myself. |
There's a handful of comments |
I don't think that should necessarily block a 2.0rc release next week |
Those are for the pyarrow csv tests, should be OK to ignore, but I'm getting around to fix them. |
It'd be good to get in #51335 for a few reasons (see the linked issues), but not a blocker in my opinion. |
I think all blockers are now merged. There seems to be a problem with pylint on master. I'll start preparing for the release and fix it if nobody does before, and I'm aiming to tag and release 2.0 RC on Thursday. Feel free to continue merging things until then, but probably worth trying to get PRs rebased more often than usual to avoid problems in master. |
Wheel builders are currently broken on Windows and uploads don't work on aarch. Can you give till Monday to work things out? |
I have a PR open for aarch uploads but it'll take until the next nightly to verify it works. |
Absolutely, I didn't see that, thanks for the heads up. Let's aim next week then, let me know if you need help. |
aarch nightly uploads are successful (I haven't tested that it triggers on a tag, though. We'd have to do the RC to figure out if that functionality works). Now, just the Windows failing tests. If we can worked out quickly, then maybe we can release on Friday. |
@phofl (The wheel builders output dtype of int64 looks more correct) |
All build blockers should be cleared for 2.0. We could technically release on Thursday as originally planned, but I'd like the nightlies to do another full green run to flush out issues(which will be caught in downstream project's CI). |
Yeah I think this is a good idea |
Yeah releasing Friday (or even Monday) sounds good |
Plan is still to release tomorrow? |
Just to note, these unclosed files are from matplotlib and not related to us #44844 (comment) |
PyPI packages already available. Tested for my platform, and everything seems fine. Still waiting for the conda-forge CI to finish (arm builds take longer). If all is green the conda-forge PR will automerge and packages for most architectures should be available in less than one hour. I'll send an update here and announce the release once most conda-forge packages are available.
Yep, it's fine now. Not sure if I was clear, but it was only backporting to 2.0.x which was a problem. It's fine now, but as expected just for things that should go into the final 2.0.0 release. |
The Python standard documentation has an explicit example of using https://docs.python.org/3/library/devmode.html#resourcewarning-example |
ppc64 still failing in conda forge, moving forward with the rest |
All conda-forge packages published (except ppc64), and release announced. Unless there is something unexpected with the second release candidate, the plan is to release the final 2.0.0 in around two weeks. We should do something with ppc64 before that. If the problem isn't easy to fix, should we xfail the date mismatches for that architecture, or should we remove ppc64 from conda-forge builds? No strong preference from my side. |
Pandas is expecting to release v2 in two weeks (pandas-dev/pandas#46776 (comment)). But we are still incompatible with their main branch: - #7441 - #7420 This PR pins pandas to `<2`
* Pin pandas < 2 Pandas is expecting to release v2 in two weeks (pandas-dev/pandas#46776 (comment)). But we are still incompatible with their main branch: - #7441 - #7420 This PR pins pandas to `<2` * modify requirements.txt * Update requirements
there's quite a few issues / PRs with the 2.0 milestone it's hard to tell which are blockers - I'm trying to remove ones which clearly aren't blockers, but for others, could people please check whether the milestone of their issues/PRs should be updated? |
Thoughts on releasing later this week or early next week? |
are your open PRs milestoned to 2.0 not blockers? if so, let's do it! probably best over the weekend or on monday, or avoid breaking code on a thursday/friday |
The ones that should get in are ready, the others are not blockers, should have cleared this out by tomorrow (hopefully) |
I'm busy this week, but I should be able to release on Monday of everything is ready. One thing that we should fix if it hasn't been addressed is the ppc64 builds. We can skip the tests for that platform if we're happy to release with the bug with wrong dates on that platform. Or we can decide to not support ppc64 and remove the wheela jobs too. @jbrockmendel could you have a look at the problem? |
Sure, is there a link? |
I don't think we created an issue, and the log is gone now, but I opened a PR to regenerate it. You should have the failures in like 3 hours: conda-forge/pandas-feedstock#158 |
Starting the release. Please do not merged things with the 2.0 milestone (I rolled the milestone of outstanding issues/PRs), and do not tag things to that milestone. You can continue merging to |
I created the 2.0.1 milestone, which is backporting to the 2.0.x branch. Feel free to add any regression issue (or anything worth backporting, but as with the 2.0 milestone, please do not merge issues with that milestone before the release is ready (it's not a big deal, but adds a bit of confusion if things are added to the 2.0.x branch at this point). |
Tag created and pushed |
awesome! thanks a tonne for doing this OK to merge to 2.0.x (e.g. backporting docs corrections)? |
Yes, I don't think merging to 2.0.x should cause any problem with the release now. |
GitHub release created: https://github.com/pandas-dev/pandas/releases/tag/v2.0.0 |
Seems like we added |
pip packages are now ready: https://pypi.org/project/pandas/#history Looks like simply adding the |
The problem with Besides that, seems like there is an issue with conda-forge: conda-forge/status#143 It starts to be late in my timezone, but if someone wants to have a look at the feedstock PR in couple of hours, and if both the windows failure and the conda-forge problem are fixed, feel free to merge. Otherwise I'll continue with this tomorrow morning UAE time. |
All good now with conda-forge, PR merged, packages should be available in one or two hours for most architectures: conda-forge/pandas-feedstock#159 |
Most packages for conda-forge are already available, and many others should be available soon: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=683592&view=results I'm going to announce the release now. |
Release complete (pending few conda-forge ARM builds) and announced. Closing this, issue for the 2.0.1 release: #52383. |
Tracking issue for the 2.0 release.
Note: pandas 2.0 is the next major release in the pandas semver-like release cycle and different from some historical discussion about the pandas future also named pandas 2.
Blockers
Scheduled
Feb 2023
References
The text was updated successfully, but these errors were encountered: