Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

todo when min support moves to python 3.9 #98

Closed
4 tasks done
maread99 opened this issue Oct 12, 2021 · 0 comments · Fixed by #323
Closed
4 tasks done

todo when min support moves to python 3.9 #98

maread99 opened this issue Oct 12, 2021 · 0 comments · Fixed by #323
Labels
TODO Todo list for feature or release

Comments

@maread99
Copy link
Collaborator

maread99 commented Oct 12, 2021

  • ExchangeCalendar class methods valid_sides and default_side to be changed to class properties (like this). EDIT 06/06/22 - NOTE: seems that defining class properties in this way may not be an option from 3.11 (same reference). If it's not going to stable then leave as is.
  • Remove following ExchangeCalendar methods deprecated in 4.0 (will be about time to remove them).
    • sessions_opens
    • sessions_closes
  • Check if it's still necessary to have the 'near-empty' setup.py file to allow for editable installs when defining meta in pyproject.toml (reference). Remove setup.py if it's no longer needed, otherwise roll this item forwards to review when bumping min support to 3.10.
  • Drop pytz in favor of zoneinfo standard library (either now or later). Looks likely that pandas 2.0 will switch to zoneinfo as its default timezone package. If it looks like pandas 2.0 could be released any time soon we might want to address this now. If it looks still to be a way off then we could roll this item forwards (to dedicated issue), although in any event pandas already supports zoneinfo and we'd be better off depending on a stdlib library than a third-party one. See Drop pytz in favor of zoneinfo standard library #322.

On bumping min version to 3.9, roll anything not addressed to a new issue 'TODO when min support moves to python 3.10'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO Todo list for feature or release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant