Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused (and undocumented) kind parameter in read_excel #4712

Closed
jtratner opened this issue Aug 30, 2013 · 2 comments · Fixed by #4713
Closed

Unused (and undocumented) kind parameter in read_excel #4712

jtratner opened this issue Aug 30, 2013 · 2 comments · Fixed by #4713
Labels
API Design IO Data IO issues that don't fit into a more specific label
Milestone

Comments

@jtratner
Copy link
Contributor

closes #4563

Why does read_excel take a kind parameter at all? It gets passed to the ExcelFile constructor, set on the object and then (as far as I can tell) never gets used for anything.

This should either be removed from the signature (which doesn't affect anything, because it will be accepted into kwds anyways) or added into the docs and then actually used for something.

if we remove it, just need to add a:

# Remove this branch in 0.14
if 'kind' in kwargs:
   warnings.warn("Kind is deprecated and will be removed in a future version of pandas")
   kwargs.pop('kind')

Was not previously being used for anything anyways.

@jtratner
Copy link
Contributor Author

also needs to be removed from the ExcelFile constructor in io/parsers along with guard.

@cancan101
Copy link
Contributor

Also will close #4563

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Design IO Data IO issues that don't fit into a more specific label
Projects
None yet
2 participants