Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Remove unused and undocumented kind keyword from read_excel #4713

Merged

Conversation

@jtratner
Copy link
Contributor

commented Aug 30, 2013

Pops kwarg and warns if you pass it (rather than passing on).

Fixes #4712

@jreback

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2013

maybe kind was meant to be engine/flavor at some point to support different backends

@jtratner

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2013

I think it might have been for xlsx/xls.

For now, it's just weird to have something in the function signature that's
completely unused, so better to remove it (but, for now, won't error out or
anything if you pass it).

@jtratner

This comment has been minimized.

Copy link
Contributor Author

commented Sep 1, 2013

@jreback and others - any objections to merging this?

CLN: Remove unused and undocumented kind keyword from read_excel
Pops kwarg and warns if you pass it (rather than passing on)
@jreback

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2013

looks good

jtratner added a commit that referenced this pull request Sep 1, 2013
Merge pull request #4713 from jtratner/remove-kind-parameter-read-excel
CLN: Remove unused and undocumented kind keyword from read_excel

@jtratner jtratner merged commit 4532fe4 into pandas-dev:master Sep 1, 2013

@jtratner jtratner deleted the jtratner:remove-kind-parameter-read-excel branch Sep 1, 2013

@jreback jreback referenced this pull request Jul 24, 2016
141 of 141 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.