Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: *args, **kwargs on resample methods #50977

Closed
mroeschke opened this issue Jan 25, 2023 · 2 comments · Fixed by #51042
Closed

DEPR: *args, **kwargs on resample methods #50977

mroeschke opened this issue Jan 25, 2023 · 2 comments · Fixed by #51042
Labels
Deprecate Functionality to remove in pandas Resample resample method

Comments

@mroeschke
Copy link
Member

xref #50913 (comment)

Similar to #50338, *args, **kwargs were deprecated and removed in 1.x for rolling-like methods, so the same should apply to resample methods as well.
@mroeschke mroeschke added Resample resample method Deprecate Functionality to remove in pandas labels Jan 25, 2023
@kostyafarber
Copy link
Contributor

I could have a go at this if nobody is currently working on it.

@phofl
Copy link
Member

phofl commented Jan 27, 2023

Sounds good!

@kostyafarber kostyafarber mentioned this issue Jan 28, 2023
Merged
2 tasks
@phofl phofl mentioned this issue Feb 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Resample resample method
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DEPR: Remove *args and **kwargs on resample methods kostyafarber/pandas
3 participants
@mroeschke @phofl @kostyafarber