Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: Enforce deprecation of args/kwargs in Window #50338

Merged
merged 1 commit into from
Dec 19, 2022
Merged

DEPR: Enforce deprecation of args/kwargs in Window #50338

merged 1 commit into from
Dec 19, 2022

Conversation

rhshadrach
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@rhshadrach rhshadrach added Deprecate Functionality to remove in pandas Window rolling, ewma, expanding labels Dec 19, 2022
@mroeschke mroeschke added this to the 2.0 milestone Dec 19, 2022
@mroeschke mroeschke merged commit 2fbea3f into pandas-dev:main Dec 19, 2022
@mroeschke
Copy link
Member

Thanks @rhshadrach (I think the failures have been addressed on main)

@rhshadrach rhshadrach deleted the enforce_rolling_depr branch December 19, 2022 22:53
This was referenced Jan 25, 2023
Merged
Closed
@kostyafarber kostyafarber mentioned this pull request Jan 28, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Window rolling, ewma, expanding
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rhshadrach @mroeschke