Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Suite: Expand Test Coverage for `script\tests\test_inconsistent_namespace.py #58865

Closed
himanshurd opened this issue May 29, 2024 · 2 comments

Comments

@himanshurd
Copy link

Add more edge cases to script\tests\test_inconsistent_namespace.py

Write new tests for empty files, files with only comments, files without pandas references, and files with multiple correct pandas imports.

@himanshurd
Copy link
Author

Can I assign to this issue?

This was referenced Jun 6, 2024
himanshurd added a commit to himanshurd/pandas that referenced this issue Jun 6, 2024
…ences Add two more tests: test_edge_cases test_mixed_good_file Fix issue pandas-dev#58865"
@mroeschke
Copy link
Member

mroeschke commented Jun 7, 2024

Thanks for this issue, but as mentioned on your other PR, I think the changed files were adequate as is.

Closing, but happy to have your contributions toward other issues labeled good first issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants