Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: losing Index/Series names master issue #9862

Closed
jreback opened this issue Apr 12, 2015 · 9 comments

Comments

Projects
None yet
8 participants
@jreback
Copy link
Contributor

commented Apr 12, 2015

cases where index names are lost in various operations, most of these involve an issue in concat

Index.name

Series.name

@jreback jreback added this to the Next Major Release milestone Apr 12, 2015

@ksanghai

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2015

I am working on this issue now.. lets see how far I can get..

@jreback

This comment has been minimized.

Copy link
Contributor Author

commented Apr 13, 2015

In [1]: Index(['a'],name='foo').append(Index(['b']))
Out[1]: Index([u'a', u'b'], dtype='object')

In [2]: Index(['a'],name='foo').append(Index(['b'])).name

ksanghai added a commit to ksanghai/pandas that referenced this issue Apr 13, 2015

jreback added a commit that referenced this issue Apr 14, 2015

@sinhrks

This comment has been minimized.

Copy link
Member

commented Apr 14, 2015

How about making testing.assert_index_equal to check name attribute (maybe optionally) to detect this kind of problems?

@jorisvandenbossche

This comment has been minimized.

Copy link
Member

commented Apr 14, 2015

+1 testing.assert_frame_equal does this already, so it seems logical that assert_index_equal can do this as well (and then we can also clean up assert_frame_equal a bit)

@jreback

This comment has been minimized.

Copy link
Contributor Author

commented Apr 14, 2015

IIRC the checking names option was turned off as a default quite a while ago, because too many things were breaking; I suspect it would be much closer nowadays. so +1 here as well.

@sinhrks

This comment has been minimized.

Copy link
Member

commented Apr 18, 2015

Added #9925 and #9926 to the list, which found by changing assert_index_equal to check index names.

@sergeny

This comment has been minimized.

Copy link

commented Apr 20, 2015

Independently stumbled upon the same thing: #9943

hsperr added a commit to hsperr/pandas that referenced this issue Apr 22, 2015

CoolRanch29 added a commit to CoolRanch29/pandas that referenced this issue Jun 3, 2015

@sinhrks sinhrks changed the title BUG: losing index names master issue BUG: losing Index/Series names master issue Jul 23, 2015

@chris-b1 chris-b1 referenced this issue May 16, 2016

Closed

PERF: DataFrame transform #13192

3 of 4 tasks complete

@jreback jreback modified the milestones: Next Major Release, High Level Issue Tracking Sep 24, 2017

@Licht-T

This comment has been minimized.

Copy link
Contributor

commented Oct 24, 2017

@jreback #8093 seems already fixed.
#8093 (comment)

@Dr-Irv

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2018

@jreback #11193 is closed by #11193
#3570 was closed since it is for Panel (remark from you is "won't fix")

@TomAugspurger TomAugspurger removed this from the High Level Issue Tracking milestone Jul 6, 2018

gfyoung added a commit that referenced this issue Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.