Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC/DEPR: port pandas.rpy to rpy2 guide #10075

Merged

Conversation

jorisvandenbossche
Copy link
Member

Addresses the doc part of #9602

@jorisvandenbossche jorisvandenbossche added Docs Deprecate Functionality to remove in pandas labels May 7, 2015
@jorisvandenbossche jorisvandenbossche added this to the 0.16.1 milestone May 7, 2015
@jorisvandenbossche jorisvandenbossche mentioned this pull request May 7, 2015
5 tasks
@TomAugspurger
Copy link
Contributor

Thanks for this. Thoughts on adding a section explaining why we're deprecating it? (no real maintainers, rpy2 is better... I think there were some others).

@jorisvandenbossche
Copy link
Member Author

Yes, indeed, good point. I was also thinking that, but in the end just wrote that it is "similar" functionality.

I think the main reason is to "avoid duplication"? (having the same functionality in both pandas and rpy2 is not needed, and anyhow, those who used pandas.rpy were in fact already using rp2)
Saying that rpy2 is better is not yet fully correct .. as there are still some things better in the pandas version to be ported (eg NaN handling, see the issue).

@TomAugspurger
Copy link
Contributor

Similar is probably good enough. I just didn't read closely enough. 👍

@ARF1
Copy link

ARF1 commented May 7, 2015

@jorisvandenbossche I just stumbled across this PR in the Travis CI build queue and was wondering how one would convert a pandas dataframe to a R dataframe with rpy2. Any chance the docs could contain a minimal how-to for this very frequent use-case?

@jorisvandenbossche
Copy link
Member Author

The pandas2ri.py2ri function as mentioned in the new docs in this PR (or even only doing pandas2ri.activate() will be enough). But I assumed knowledge of the existing functions, so this is equivalent to the convert_to_r_dataframe.
But it would be nice to also have docs geared towards new users (who didn't know the old way). But let's say that is for another PR.

@jreback
Copy link
Contributor

jreback commented May 8, 2015

lgtm. merge when ready.

jorisvandenbossche added a commit that referenced this pull request May 11, 2015
DOC/DEPR: port pandas.rpy to rpy2 guide
@jorisvandenbossche jorisvandenbossche merged commit f4d288f into pandas-dev:master May 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants