CLN: removed the 'diff' method for Index #13669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
force-pushed
the
remove-index-diff
branch
2 times, most recently
from
f82407f
to
6f42786
Compare
Current coverage is 84.52%@@ master #13669 diff @@
==========================================
Files 141 141
Lines 51145 51144 -1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 43233 43232 -1
Misses 7912 7912
Partials 0 0
|
| @@ -1949,8 +1949,6 @@ def difference(self, other): | |||
| theDiff = sorted(set(self) - set(other)) | |||
| return Index(theDiff, name=result_name) | |||
|
|
|||
| diff = deprecate('diff', difference) | |||
|
|
|||
There was a problem hiding this comment.
hmm no tests on the deprecation to remove? docs (they r prob gone, but give a check)
There was a problem hiding this comment.
I did. Otherwise, something would have failed.
There was a problem hiding this comment.
can you add in the removal of deprecations for + and - to same PR?
gfyoung
force-pushed
the
remove-index-diff
branch
from
6f42786
to
7dca659
Compare
|
ty! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated all the way back in
0.15.0here.