New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNL: remove the io.data and io.wb modules #13735

Merged
merged 1 commit into from Jul 24, 2016

Conversation

Projects
None yet
3 participants
@jorisvandenbossche
Member

jorisvandenbossche commented Jul 21, 2016

Closes #13724

return frame
raise ImportError(
"The pandas.io.data module is moved to a separate package "
"(pandas-datareader). After installing the pandas-datareader package "

This comment has been minimized.

@jreback

jreback Jul 21, 2016

Contributor

need an issue to remove this in the future :>

This comment has been minimized.

@jorisvandenbossche

jorisvandenbossche Jul 21, 2016

Member

yep, added an entry in the overview at #6581

idx = data.str.contains(string, case=case)
out = _cached_series.ix[idx].dropna()
return out
raise ImportError(

This comment has been minimized.

@jreback

jreback Jul 21, 2016

Contributor

I would just blow this one away; no exception

This comment has been minimized.

@jorisvandenbossche

jorisvandenbossche Jul 21, 2016

Member

It doesn't is much effort to keep it .. ? (and it's for the same reason as the import error in data.py), but indeed probably used a lot less

@jsexauer jsexauer referenced this pull request Jul 21, 2016

Open

DEPR: deprecations from prior versions #6581

0 of 83 tasks complete
@jreback

This comment has been minimized.

Contributor

jreback commented Jul 24, 2016

@jorisvandenbossche ok lgtm (and fine to have error on both).

@jorisvandenbossche jorisvandenbossche merged commit 81a5c98 into pandas-dev:master Jul 24, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@jorisvandenbossche jorisvandenbossche deleted the jorisvandenbossche:remove-datareader branch Jul 24, 2016

@jreback

This comment has been minimized.

Contributor

jreback commented Jul 24, 2016

whoo hoo!

@gfyoung

This comment has been minimized.

Member

gfyoung commented Jul 24, 2016

@jorisvandenbossche : any reason why we just didn't add pandas-datareader as a dependency and do a try-except block with import pandas-datareader? I ask because in the README for pandas-datareader, it seems to imply that pandas should be dependent on pandas-datareader by now.

@jreback

This comment has been minimized.

Contributor

jreback commented Jul 24, 2016

the dependency is the other way
u can submit a PR to pandas-datareader if you want to change the wording

@gfyoung

This comment has been minimized.

Member

gfyoung commented Jul 24, 2016

@jreback : fair enough, but I still don't get why we didn't do try-except with pandas-datareader, or rather, why we even have these files (wb.py and data.py) at all in the pandas library still.

@jreback

This comment has been minimized.

Contributor

jreback commented Jul 24, 2016

they raise a more helpful message

@gfyoung

This comment has been minimized.

Member

gfyoung commented Jul 24, 2016

@jreback : Ah, so we're helping people with transitioning from io.data to pandas-datareader?

@jreback

This comment has been minimized.

Contributor

jreback commented Jul 24, 2016

of course -

@jorisvandenbossche

This comment has been minimized.

Member

jorisvandenbossche commented Jul 25, 2016

Hmm, didn't see that in the readme of pandas-datareader (and it's not how it is phrased in the pandas docs). Anyway, I see that your PR over there has already been merged.
As I said in the issue #13724, there was some unresolved discussion about this at the time we deprecated it and created pandas-datareader (I think @hayd was in favor of doing it like you say).

Keeping the file with the custom import error is indeed to have a more helpful error for transitioning to pandas-datareader.

gfyoung added a commit to forking-repos/pandas that referenced this pull request Dec 3, 2017

CLN: Remove io.data and io.wb
Deprecated in 0.17.0.

xref pandas-devgh-13735.

@jreback jreback referenced this pull request Dec 3, 2017

Open

DEPR: deprecations log for removed issues #13777

115 of 115 tasks complete

gfyoung added a commit to forking-repos/pandas that referenced this pull request Dec 4, 2017

CLN: Remove io.data and io.wb
Deprecated in 0.17.0.

xref pandas-devgh-13735.

jreback added a commit that referenced this pull request Dec 5, 2017

CLN: Remove io.data and io.wb (#18612)
Deprecated in 0.17.0.

xref gh-13735.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment