Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: Panel4d and panelND #13776

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@jreback
Copy link
Contributor

commented Jul 24, 2016

closes #13564

@jreback jreback added the Deprecate label Jul 24, 2016

@jreback jreback added this to the 0.19.0 milestone Jul 24, 2016

@jreback

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2016

This is was a PITA (because some things produce warnings in PY2 but not in PY3) :<

@jorisvandenbossche @wesm @shoyer

@jreback

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2016

@shoyer @MaximilianR esp have a look at the warnings (e.g. maybe have a specific page)?

@jsexauer jsexauer referenced this pull request Jul 24, 2016

Open

DEPR: deprecations from prior versions #6581

0 of 98 tasks complete

@jreback jreback referenced this pull request Jul 24, 2016

Closed

CLN: Removed SparsePanel #13778

@shoyer

This comment has been minimized.

Copy link
Member

commented Jul 24, 2016

Can we add the deprecation notice to the docstrings for PanelND and Panel4D, too?

@MaximilianR Let's see if we can finish up that doc page on xarray for panel users (pydata/xarray#832) -- it would be great to be able to link to that in the pandas docs.

@jorisvandenbossche

View changes

pandas/core/panel4d.py Outdated
@@ -37,6 +38,9 @@
def panel4d_init(self, data=None, labels=None, items=None, major_axis=None,
minor_axis=None, copy=False, dtype=None):

# deprecation GH13564
warnings.warn("Panel4D is deprecated and will be removed in a "
"future version", FutureWarning, stacklevel=2)

This comment has been minimized.

Copy link
@jorisvandenbossche

jorisvandenbossche Jul 24, 2016

Member

Maybe refer to xarray here as well? (like in the docs)

@jorisvandenbossche

This comment has been minimized.

Copy link
Member

commented Jul 24, 2016

Oh boy, that will be a joy if when we can remove it :-)
Too late for now, but isn't there a way to eg test the warning once, and be able to mute them for all other tests?

@jreback

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2016

I wish - the problem is that FutureWarninh is generic so No easy way

@jorisvandenbossche

This comment has been minimized.

Copy link
Member

commented Jul 24, 2016

Can't you filter with a regex on the message or module?

@jreback

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2016

I gave it a try - u r welcome to change it - it's buggy in 27 I think

@jorisvandenbossche

This comment has been minimized.

Copy link
Member

commented Jul 24, 2016

For the next big depr then :-)

@codecov-io

This comment has been minimized.

Copy link

commented Jul 24, 2016

Current coverage is 85.32% (diff: 100%)

No coverage report found for master at 4dd734c.

Powered by Codecov. Last update 4dd734c...38641c7

@jreback jreback force-pushed the jreback:panelnd branch Jul 25, 2016

@max-sixty

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2016

@MaximilianR Let's see if we can finish up that doc page on xarray for panel users (pydata/xarray#832) -- it would be great to be able to link to that in the pandas docs.

I'll have a go this week!

@jreback jreback force-pushed the jreback:panelnd branch to 3f55809 Jul 25, 2016

@jreback

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2016

@jorisvandenbossche updated.

@shoyer
cc @MaximilianR
we can always change the xarray link points later (I think we have an issue for that anyhow). As these need to go in the .to_xarray() doc-string as well.

@@ -58,11 +58,10 @@ class TestPDApi(Base, tm.TestCase):

# these are already deprecated; awaiting removal
deprecated_classes = ['SparsePanel', 'TimeSeries', 'WidePanel',
'SparseTimeSeries']
'SparseTimeSeries', 'Panel', 'Panel4D']

This comment has been minimized.

Copy link
@jorisvandenbossche

jorisvandenbossche Jul 25, 2016

Member

I don't think Panel is already deprecated?

@jorisvandenbossche

This comment has been minimized.

Copy link
Member

commented Jul 25, 2016

Small comment/question, for the rest ready to merge for me. The doc link can indeed be updated later.

@jreback jreback closed this in 309e1fe Jul 25, 2016

@jreback jreback referenced this pull request Jan 3, 2018

Open

DEPR: deprecations log for removed issues #13777

116 of 116 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.