Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Removed DataFrame.to_wide #14039

Merged
merged 1 commit into from
Aug 19, 2016

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Aug 19, 2016

to_wide was deprecated since 2011 (1134c9f)

xref #13777

No tests for this deprecation beforehand to remove 😞

@codecov-io
Copy link

codecov-io commented Aug 19, 2016

Current coverage is 85.25% (diff: 100%)

Merging #14039 into master will decrease coverage by <.01%

@@             master     #14039   diff @@
==========================================
  Files           139        139          
  Lines         50380      50379     -1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          42953      42952     -1   
  Misses         7427       7427          
  Partials          0          0          

Powered by Codecov. Last update 453bc26...7879d54

@@ -78,8 +78,7 @@
OrderedDict, raise_with_traceback)
from pandas import compat
from pandas.compat.numpy import function as nv
from pandas.util.decorators import (deprecate, Appender, Substitution,
deprecate_kwarg)
from pandas.util.decorators import deprecate, Appender, Substitution
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's deprecate that should be removed, not deprecate_kwarg
(hence the travis failures)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good point. Done.

@@ -894,6 +894,7 @@ Removal of prior version deprecations/changes
- ``Panel.shift()`` has dropped the ``lags`` parameter in favour of ``periods`` (:issue:`14041`)
- ``pd.Index`` has dropped the ``diff`` method in favour of ``difference`` (:issue:`13669`)

- ``pd.DataFrame`` has dropped the ``to_wide`` method in favour of ``to_panel`` (:issue:`14039`)
Copy link
Contributor

@jreback jreback Aug 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you audit the favour -> favor (or just pick one) for all of these lines. I know trivial.......

@jreback
Copy link
Contributor

jreback commented Aug 19, 2016

lgtm. ping on green.

@jorisvandenbossche
Copy link
Member

Let's leave that for another PR :-) (I/we will do a full read through of the whatsnew file anyway)

@jorisvandenbossche jorisvandenbossche merged commit 53447f4 into pandas-dev:master Aug 19, 2016
@jorisvandenbossche
Copy link
Member

@gfyoung Thanks!

@gfyoung gfyoung deleted the to-wide-remove branch August 20, 2016 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants