Bug: Made it so that 0 was included in uint8 #14404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verhalenn
commented
Oct 12, 2016
•
verhalenn
commented
- closes BUG: pd.to_numeric(..., downcast='unsigned') should accept 0 #14401
- tests added / passed
- passes git diff upstream/master | flake8 --diff
- whatsnew entry
|
pls add a test and a release note (0.19.1) |
verhalenn
changed the title
|
That should do it although it's not showing the commits. |
|
u can try force pushing |
Current coverage is 85.26% (diff: 100%)@@ master #14404 diff @@
==========================================
Files 140 140
Lines 50634 50634
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 43173 43173
Misses 7461 7461
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.