BUG: Patch maybe_convert_objects uint64 handling #14951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes method robust against known NumPy bug that you can't compare uint64 against int64 because they are casted to float64 during the comparison, causing truncation.
Current coverage is 84.64% (diff: 100%)@@ master #14951 diff @@
==========================================
Files 144 144
Lines 51021 51021
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 43188 43188
Misses 7833 7833
Partials 0 0
|
|
thanks! |
ShaharBental
pushed a commit
to ShaharBental/pandas
that referenced
this pull request
Dec 26, 2016
Makes method robust against known NumPy bug that you can't compare uint64 against int64 because they are casted to float64 during the comparison, causing truncation.
jreback
pushed a commit
that referenced
this pull request
Jan 17, 2017
1) Introduces and propagates `UInt64Index`, an index specifically for `uint`. xref #14935 2) <strike> Patches bug from #14916 that makes `maybe_convert_objects` robust against the known `numpy` bug that `uint64` cannot be compared to `int64`. This bug was caught during testing of `UInt64Index`. </strike> **UPDATE**: Patched in #14951 Author: gfyoung <gfyoung17@gmail.com> Closes #14937 from gfyoung/create-uint64-index and squashes the following commits: 8ab6fbd [gfyoung] ENH: Create and propagate UInt64Index
AnkurDedania
pushed a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
1) Introduces and propagates `UInt64Index`, an index specifically for `uint`. xref pandas-dev#14935 2) <strike> Patches bug from pandas-dev#14916 that makes `maybe_convert_objects` robust against the known `numpy` bug that `uint64` cannot be compared to `int64`. This bug was caught during testing of `UInt64Index`. </strike> **UPDATE**: Patched in pandas-dev#14951 Author: gfyoung <gfyoung17@gmail.com> Closes pandas-dev#14937 from gfyoung/create-uint64-index and squashes the following commits: 8ab6fbd [gfyoung] ENH: Create and propagate UInt64Index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes method robust against known
numpybug that you can't compareuint64againstint64because they are casted to
float64during the comparison, causing truncation.xref #14937.
Follow-up to #14916.