Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: remove statsmodels as a dependency #15353

Closed
wants to merge 1 commit into from

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Feb 9, 2017

remove pd.ols, pd.fama_macbeth from top-level namespace

xref #11898
closes wesm/pandas2#26

previously deprecated in 0.18.0

@jreback jreback added Deprecate Functionality to remove in pandas Stats labels Feb 9, 2017
@jreback jreback added this to the 0.20.0 milestone Feb 9, 2017
@codecov-io
Copy link

codecov-io commented Feb 9, 2017

Codecov Report

Merging #15353 into master will increase coverage by 2.38%.

@@            Coverage Diff             @@
##           master   #15353      +/-   ##
==========================================
+ Coverage   86.32%   88.71%   +2.38%     
==========================================
  Files         141      133       -8     
  Lines       51163    49466    -1697     
==========================================
- Hits        44167    43884     -283     
+ Misses       6996     5582    -1414
Impacted Files Coverage Δ
pandas/stats/api.py 100% <ø> (ø)
pandas/util/print_versions.py 15.71% <ø> (ø)
pandas/util/testing.py 82.72% <ø> (+0.18%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d38d142...9563740. Read the comment docs.

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 !

@@ -396,7 +396,7 @@ Removal of prior version deprecations/changes
- The ``pandas.io.ga`` module with a ``google-analytics`` interface is removed (:issue:`11308`).
Similar functionality can be found in the `Google2Pandas <https://github.com/panalysis/Google2Pandas>`__ package.
- ``pd.to_datetime`` and ``pd.to_timedelta`` have dropped the ``coerce`` parameter in favor of ``errors`` (:issue:`13602`)

- ``pandas.stats.fama_macbeth``, ``pandas.stats.ols``, ``pandas.stats.plm`` and ``pandas.stats.var``, as well as the top-level ``pandas.fama_macbeth`` and ``pandas.ols`` routines are removed. Similar functionailty can be found in the ``statsmodels`` package. (:issue:`11898`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe make statsmodels a link to its homepage?

@@ -17,5 +17,4 @@ xlsxwriter
sqlalchemy
numexpr
bottleneck
statsmodels
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

statsmodels is still used for an example in the docs (I think the pipe example), so should leave it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

remove pd.ols, pd.fama_macbeth from top-level namespace

xref pandas-dev#11898
@jreback
Copy link
Contributor Author

jreback commented Feb 9, 2017

Merging #15353 into master will increase coverage by 2.38%

a nice way of increasing coverage :>

@jreback jreback closed this in c1bd201 Feb 9, 2017
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this pull request Mar 21, 2017
remove pd.ols, pd.fama_macbeth from top-level namespace

xref pandas-dev#11898
closes wesm/pandas2#26

previously deprecated in 0.18.0

Author: Jeff Reback <jeff@reback.net>

Closes pandas-dev#15353 from jreback/stats and squashes the following commits:

9563740 [Jeff Reback] DEPR: remove statsmodels as a dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove pandas.stats (except moments.py)
3 participants