Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: remove deprecated irow, icol, iget, iget_value (GH10711) #15547

Closed
wants to merge 1 commit into from
Closed

CLN: remove deprecated irow, icol, iget, iget_value (GH10711) #15547

wants to merge 1 commit into from

Conversation

jorisvandenbossche
Copy link
Member

xref #6581

@jorisvandenbossche jorisvandenbossche added Clean Deprecate Functionality to remove in pandas labels Mar 2, 2017
@jorisvandenbossche jorisvandenbossche added this to the 0.20.0 milestone Mar 2, 2017
@jreback jreback mentioned this pull request Mar 2, 2017
Closed
@codecov-io
Copy link

Codecov Report

Merging #15547 into master will decrease coverage by -0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #15547      +/-   ##
==========================================
- Coverage   91.06%   91.03%   -0.03%     
==========================================
  Files         136      136              
  Lines       49104    49083      -21     
==========================================
- Hits        44718    44685      -33     
- Misses       4386     4398      +12
Impacted Files Coverage Δ
pandas/core/frame.py 97.73% <ø> (-0.11%) ❌
pandas/core/series.py 94.89% <ø> (-0.05%) ❌
pandas/core/groupby.py 94.99% <ø> (-0.01%) ❌
pandas/io/gbq.py 40% <0%> (-46.67%) ❌
pandas/util/decorators.py 67.92% <0%> (-0.95%) ❌
pandas/tools/merge.py 91.78% <0%> (-0.35%) ❌

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f91d5a...06ea1bb. Read the comment docs.

jreback
jreback approved these changes Mar 2, 2017
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always nice to remove code!

@jreback jreback closed this in 2eb6d38 Mar 2, 2017
mcocdawc pushed a commit to mcocdawc/pandas that referenced this pull request Mar 2, 2017
@jorisvandenbossche @mcocdawc
CLN: remove deprecated irow, icol, iget, iget_value (GH10711)
55c6d52 
xref pandas-dev#6581

Author: Joris Van den Bossche <jorisvandenbossche@gmail.com>

Closes pandas-dev#15547 from jorisvandenbossche/remove-irow-icol and squashes the following commits:

06ea1bb [Joris Van den Bossche] CLN: remove deprecated irow, icol, iget, iget_value (GH10711)
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this pull request Mar 21, 2017
@jorisvandenbossche @AnkurDedania
CLN: remove deprecated irow, icol, iget, iget_value (GH10711)
7cef767 
xref pandas-dev#6581

Author: Joris Van den Bossche <jorisvandenbossche@gmail.com>

Closes pandas-dev#15547 from jorisvandenbossche/remove-irow-icol and squashes the following commits:

06ea1bb [Joris Van den Bossche] CLN: remove deprecated irow, icol, iget, iget_value (GH10711)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Clean Deprecate Functionality to remove in pandas
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jorisvandenbossche @codecov-io @jreback