Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Add test for groupby mean of ints #16670

Merged
merged 1 commit into from
Jun 11, 2017

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Jun 11, 2017

Title is self-explanatory.

Closes #11199.

@codecov
Copy link

codecov bot commented Jun 11, 2017

Codecov Report

Merging #16670 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16670   +/-   ##
=======================================
  Coverage   90.93%   90.93%           
=======================================
  Files         161      161           
  Lines       49269    49269           
=======================================
  Hits        44802    44802           
  Misses       4467     4467
Flag Coverage Δ
#multiple 88.69% <ø> (ø) ⬆️
#single 40.22% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18a428d...8802f44. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 11, 2017

Codecov Report

Merging #16670 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16670   +/-   ##
=======================================
  Coverage   90.93%   90.93%           
=======================================
  Files         161      161           
  Lines       49269    49269           
=======================================
  Hits        44802    44802           
  Misses       4467     4467
Flag Coverage Δ
#multiple 88.69% <ø> (ø) ⬆️
#single 40.22% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18a428d...8802f44. Read the comment docs.

@jreback jreback added Dtype Conversions Unexpected or buggy dtype conversions Groupby labels Jun 11, 2017
@jreback jreback added this to the 0.21.0 milestone Jun 11, 2017
@jreback
Copy link
Contributor

jreback commented Jun 11, 2017

lgtm. if you'd have a look at the xref issues (which are closed):

xref #15091
xref #3707

to see if we want to add any tests from those.

@gfyoung
Copy link
Member Author

gfyoung commented Jun 11, 2017

to see if we want to add any tests from those.

Why not, if possible? 😄 I can add those as separate PR's.

@jreback
Copy link
Contributor

jreback commented Jun 11, 2017

ok then (FYI sometimes I have xref duplicate issues that have potentially other tests). yes a new PR is fine.

@jreback jreback merged commit 5a6f50d into pandas-dev:master Jun 11, 2017
@gfyoung gfyoung deleted the test-for-11199 branch June 11, 2017 23:30
@gfyoung
Copy link
Member Author

gfyoung commented Jun 11, 2017

@jreback : Unfortunately, both issues are still valid on master. They actually were not addressed by the fixing of #11199 as you had imagined. 😢

@jreback
Copy link
Contributor

jreback commented Jun 12, 2017

hmm can u create a new issue with he simplest repro possible for both of those (and cited the old)
there is lots of chatter on those

@gfyoung
Copy link
Member Author

gfyoung commented Jun 12, 2017

@jreback #3707 has been resurrected as #16674, but with a slightly broader focus.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dtype Conversions Unexpected or buggy dtype conversions Groupby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants