BUG: Fix css for displaying DataFrames in notebook #16792 #16879
Conversation
|
Could you attach before / after screenshots? |
TomAugspurger
added
the
IO HTML
Index Vertical Alignment with Wrapping TextBefore
After
Header Horizontal Alignment with Named Index and non-MultiIndex ColumnsBefore
After
Header Horizontal Alignment with Named Index and MultiIndex ColumnsBefore
After
|
|
Thanks, I think these all look better. You'll need to update some of the tests, as they were checking the old structure. But +1 on the changes so far. |
|
can you update |
|
Hello @margotphoenix! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on September 20, 2017 at 19:29 Hours UTC |
|
Apologies for the delay in updating. I was out of town. |
Codecov Report
@@ Coverage Diff @@
## master #16879 +/- ##
==========================================
- Coverage 91.22% 91.18% -0.05%
==========================================
Files 163 163
Lines 49625 49636 +11
==========================================
- Hits 45270 45259 -11
- Misses 4355 4377 +22
Continue to review full report at Codecov.
|
|
@margotphoenix : You should also add a |
No worries. We've had to wait MUCH longer than a day for updates before 😄 |
doc/source/whatsnew/v0.21.0.txt
Outdated
| @@ -160,6 +160,7 @@ I/O | |||
| ^^^ | |||
|
|
|||
| - Bug in :func:`read_csv` in which non integer values for the header argument generated an unhelpful / unrelated error message (:issue:`16338`) | |||
| - Bug in ``DataFrame.to_html()`` with ``notebook=True`` where DataFrames with named indexes or non-MultiIndex indexes had undesired horizontal or vertical alignment for column or row labels, respectively (:issue:`16792`) | |||
There was a problem hiding this comment.
indexes --> indices
", respectively" --> " respectively"
There was a problem hiding this comment.
Dammit, I had "indices" right then I changed it right before committing
There was a problem hiding this comment.
indices/indexes is actually both correct :-)
http://grammarist.com/usage/indexes-indices/
|
can you rebase / update and see if you can get tests passing |
|
done |
There was a problem hiding this comment.
This looks good!
Do you have time to update for the last comment of @jreback ?
Removed trailing whitespace
|
Yeah, I think so. Just removed some trailing whitespace in 9cd4d5a |
|
@margotphoenix Thanks! |
* COMPAT: pandas TimeGrouper xref pandas-dev/pandas#16747 * COMPAT: For pandas 0.21 CategoricalDtype * COMPAT: For pandas 0.21.0 HTML repr changes pandas-dev/pandas#16879 * COMPAT: For pandas 0.21.0 numexpr import pandas-dev/pandas#17710 * COMPAT: Default for inplace is now False in eval pandas-dev/pandas#11149
git diff upstream/master --name-only -- '*.py' | flake8 --diff(On Windows,git diff upstream/master -u -- "*.py" | flake8 --diffmight work as an alternative.)