CLN: replace %s syntax with .format in tslibs/timedeltas

[WillAyd]

• Progress towards CLN: replace %s formatting syntax with .format #16130
• tests passed
• passes git diff upstream/master -u -- "*.py" | flake8 --diff

[WillAyd]

FWIW I didn't see what the point of the 'even_day' argument was to _repr_base in timedeltas.pyx. From both the test cases provided and the control flow, unless I'm missing something that argument is no different from passing nothing or None explicitly.

Left alone for now but if you want me to remove it won't be a problem

[jreback]

lgtm. IIRC even_day was copied from Timestamp originally (when I wrote this repr). if its not used, you can remove.

[WillAyd]

I’ll go ahead and update the docstring to remove. Did you want to keep the test cases for backwards compatibility or would you rather I delete and just stick with the cases for None?

[jreback]

I’ll go ahead and update the docstring to remove. Did you want to keep the test cases for backwards compatibility or would you rather I delete and just stick with the cases for None?

ok to delete; these are only tests, yes?

[WillAyd]

It looks like the tests and one piece of code in pandas/io/formats/format.py at line 2277 to change

format = ‘even_day’

To

format = None

It looks like there’s already a test case called test_timedelta in the tests/io/formats/test_format.py module to regression test that.

Sorry for any formatting issues - sent from my phone.

[codecov]

Codecov Report

Merging #18405 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #18405      +/-   ##
==========================================
- Coverage   91.36%   91.34%   -0.02%     
==========================================
  Files         164      164              
  Lines       49733    49733              
==========================================
- Hits        45439    45430       -9     
- Misses       4294     4303       +9

Flag	Coverage Δ
#multiple	89.14% <100%> (ø)	⬆️
#single	39.62% <0%> (-0.07%)	⬇️

Impacted Files	Coverage Δ
pandas/io/formats/format.py	96.01% <100%> (ø)	⬆️
pandas/io/gbq.py	25% <0%> (-58.34%)	⬇️
pandas/core/frame.py	97.8% <0%> (-0.1%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4a2cd3...03e4d41. Read the comment docs.

[jreback]

thanks!