Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Add tests for Categorical.is_dtype_equal against Series #19045

Merged
merged 1 commit into from
Jan 3, 2018

Conversation

jschendel
Copy link
Member

Issue is already fixed on 0.22.0 (so really probably fixed in 0.21.x), just adding tests to ensure that there's not a regression. Didn't add a whatsnew entry since this behavior already exists in a released version, but can add one if need be.

@codecov
Copy link

codecov bot commented Jan 3, 2018

Codecov Report

Merging #19045 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19045      +/-   ##
==========================================
- Coverage   91.57%   91.54%   -0.03%     
==========================================
  Files         150      150              
  Lines       48942    48942              
==========================================
- Hits        44818    44804      -14     
- Misses       4124     4138      +14
Flag Coverage Δ
#multiple 89.9% <ø> (-0.03%) ⬇️
#single 41.75% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_converter.py 65.22% <0%> (-1.74%) ⬇️
pandas/util/testing.py 84.74% <0%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab000a9...151c76a. Read the comment docs.

@jreback jreback added Categorical Categorical Data Type Testing pandas testing functions or related to the test suite labels Jan 3, 2018
@jreback jreback added this to the 0.23.0 milestone Jan 3, 2018
@jreback jreback merged commit 9e44182 into pandas-dev:master Jan 3, 2018
@jreback
Copy link
Contributor

jreback commented Jan 3, 2018

thanks @jschendel

@jschendel jschendel deleted the cat-is-dtype-equal branch January 3, 2018 15:21
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Categorical Categorical Data Type Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API/BUG: Categorical.is_dtype_equal doesn't compare to Series
2 participants