Fix uncaught OutOfBounds in array_to_datetime #19612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @jbrockmendel! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on February 10, 2018 at 18:15 Hours UTC |
Codecov Report
@@ Coverage Diff @@
## master #19612 +/- ##
=======================================
Coverage 91.59% 91.59%
=======================================
Files 150 150
Lines 48807 48807
=======================================
Hits 44704 44704
Misses 4103 4103
Continue to review full report at Codecov.
|
jreback
requested changes
Feb 10, 2018
pandas/tests/tslibs/test_tslib.py
Outdated
| import pandas.util.testing as tm | ||
|
|
||
|
|
||
| class TestArrayToDatetime(object): |
There was a problem hiding this comment.
hmm this should be in pandas/tests/indexes/datetimes/test_tools.py. I know you are ceating new locations is fine. but would rather move all of tools testing there (in a new PR).
|
does this have a referenced issue? needs a whatsnew note |
None that I found. |
jreback
approved these changes
Feb 11, 2018
|
thanks! |
harisbal
pushed a commit
to harisbal/pandas
that referenced
this pull request
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to convert_datetime_to_tsobject has a check_dts_bounds in it. One of the usages in array_to_datetime gets that right, the other misses it.