New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uncaught OutOfBounds in array_to_datetime #19612

Merged
merged 8 commits into from Feb 11, 2018

Conversation

Projects
None yet
3 participants
@jbrockmendel
Member

jbrockmendel commented Feb 9, 2018

The call to convert_datetime_to_tsobject has a check_dts_bounds in it. One of the usages in array_to_datetime gets that right, the other misses it.

@pep8speaks

This comment has been minimized.

pep8speaks commented Feb 9, 2018

Hello @jbrockmendel! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on February 10, 2018 at 18:15 Hours UTC

jbrockmendel added some commits Feb 9, 2018

@codecov

This comment has been minimized.

codecov bot commented Feb 9, 2018

Codecov Report

Merging #19612 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19612   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files         150      150           
  Lines       48807    48807           
=======================================
  Hits        44704    44704           
  Misses       4103     4103
Flag Coverage Δ
#multiple 89.96% <ø> (ø) ⬆️
#single 41.73% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7797b4...9999e2d. Read the comment docs.

import pandas.util.testing as tm
class TestArrayToDatetime(object):

This comment has been minimized.

@jreback

jreback Feb 10, 2018

Contributor

hmm this should be in pandas/tests/indexes/datetimes/test_tools.py. I know you are ceating new locations is fine. but would rather move all of tools testing there (in a new PR).

@jreback

This comment has been minimized.

Contributor

jreback commented Feb 10, 2018

does this have a referenced issue? needs a whatsnew note

@jreback jreback added the Timeseries label Feb 10, 2018

@jbrockmendel

This comment has been minimized.

Member

jbrockmendel commented Feb 10, 2018

does this have a referenced issue?

None that I found.

@jreback jreback added this to the 0.23.0 milestone Feb 11, 2018

@jreback jreback merged commit efce492 into pandas-dev:master Feb 11, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jreback

This comment has been minimized.

Contributor

jreback commented Feb 11, 2018

thanks!

@jbrockmendel jbrockmendel deleted the jbrockmendel:coerce branch Feb 11, 2018

harisbal pushed a commit to harisbal/pandas that referenced this pull request Feb 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment