Join GitHub today
ENH: Add option to disable MathJax (#19824). #19856
This prevents MathJax from processing table contents:
I'm hoping for a code review, to find out if this might be accepted. If so, I'll add the tests/docs.
@davidchall : Thanks for the PR! For future reference, you should probably wait for us to weigh in on your filed issue before opening a PR. That's where we would "accept" the idea or not.
Once it's at the PR stage, we will not accept the changes until you add the documentation and tests.
referenced this pull request
Feb 23, 2018
@@ Coverage Diff @@ ## master #19856 +/- ## ========================================= Coverage ? 91.66% ========================================= Files ? 150 Lines ? 49039 Branches ? 0 ========================================= Hits ? 44951 Misses ? 4088 Partials ? 0
Thanks, your approach seems reasonable.
As far as testing goes, could you add one that calls
_repr_html_ with the default and in a context manager with this set to false. Then you can assert that
tex2jax_ignore is or isn't in the output.
Also we'll want to add a release note.
However, I have noticed that