ENH: Allow Timestamp to accept Nanosecond argument #19889

mroeschke · 2018-02-25T02:22:00Z

closes ENH: Timestamp constructor does not accept nanosecond arg #18898
tests added / passed
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

Needed to add a new nanos argument to convert_to_tsobject arguments from Timestamp.__new__ dispatches to this function (and datetime.datetime cannot take a nanosecond argument).

jbrockmendel · 2018-02-25T04:45:36Z

pandas/_libs/tslibs/conversion.pyx

    elif PyDate_Check(ts):
        # Keep the converter same as PyDateTime's
        ts = datetime.combine(ts, datetime_time())
-        return convert_datetime_to_tsobject(ts, tz)
+        return convert_datetime_to_tsobject(ts, tz, nanos)


Does it make sense to accept nanos with datetime.date?

Although Timestamp automatically appends a time to a passed datetime.date, you do make a good point. Looks like passing other hour/minute/second kwargs will be ignored (should maybe raise in the future?), so makes sense for nanos to be (at least) ignored as well.

In [3]: Timestamp(date(2000, 1, 1), hour=2) Out[3]: Timestamp('2000-01-01 00:00:00')

jbrockmendel · 2018-02-25T04:48:05Z

pandas/_libs/tslibs/timestamps.pyx


        if tzinfo is not None:
            # User passed tzinfo instead of tz; avoid silently ignoring
            tz, tzinfo = tzinfo, None

-        ts = convert_to_tsobject(ts_input, tz, unit, 0, 0)
+        ts = convert_to_tsobject(ts_input, tz, unit, 0, 0, nanosecond or 0)


What if we get here with a string ts_input with conflicting nanos? I think it might be better to accept nanos only in combination with other integer args/kwargs.

Currently (and in this PR), the Timestamp constructor will just parse the string and ignore all additional passed kwargs related to the values of each datetime element:

In [7]: Timestamp('2010-10-10 12:59:59.999999999', hour=0, nanosecond=16) Out[7]: Timestamp('2010-10-10 12:59:59.999999999')

The nanosecond kwarg will only be used if a datetime.datetime is passed or other datetime element kwargs are passed. As mentioned in my other comment, we might also want to raise in the situation above.

I agree here, the nanoscecond kw must only be used when kwargs are passed

codecov · 2018-02-25T05:44:19Z

Codecov Report

Merging #19889 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #19889      +/-   ##
==========================================
+ Coverage   91.65%   91.68%   +0.02%     
==========================================
  Files         150      150              
  Lines       48915    48915              
==========================================
+ Hits        44835    44847      +12     
+ Misses       4080     4068      -12

Flag	Coverage Δ
#multiple	`90.06% <ø> (+0.02%)`	⬆️
#single	`41.83% <ø> (ø)`	⬆️

Impacted Files	Coverage Δ
pandas/plotting/_converter.py	`66.95% <0%> (+1.73%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10cc8f4...1c6e23d. Read the comment docs.

codecov · 2018-02-25T05:44:21Z

Codecov Report

Merging #19889 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #19889      +/-   ##
==========================================
+ Coverage   91.66%   91.66%   +<.01%     
==========================================
  Files         150      150              
  Lines       48969    48976       +7     
==========================================
+ Hits        44886    44896      +10     
+ Misses       4083     4080       -3

Flag	Coverage Δ
#multiple	`90.04% <ø> (ø)`	⬆️
#single	`41.86% <ø> (+0.01%)`	⬆️

Impacted Files	Coverage Δ
pandas/core/indexes/datetimelike.py	`96.83% <0%> (-0.5%)`	⬇️
pandas/core/series.py	`94.24% <0%> (-0.18%)`	⬇️
pandas/core/indexes/datetimes.py	`95.5% <0%> (-0.11%)`	⬇️
pandas/core/sparse/series.py	`95.2% <0%> (-0.05%)`	⬇️
pandas/core/indexes/timedeltas.py	`91.17% <0%> (-0.04%)`	⬇️
pandas/core/strings.py	`98.31% <0%> (ø)`	⬆️
pandas/core/frame.py	`97.18% <0%> (ø)`	⬆️
pandas/io/parsers.py	`95.32% <0%> (ø)`	⬆️
pandas/core/dtypes/concat.py	`99.16% <0%> (+0.01%)`	⬆️
pandas/core/indexes/period.py	`94.65% <0%> (+1.3%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e4c50a...c81ec57. Read the comment docs.

jreback · 2018-02-25T16:26:38Z

pandas/_libs/tslibs/timestamps.pyx

        elif is_integer_object(freq):
            # User passed positional arguments:
            # Timestamp(year, month, day[, hour[, minute[, second[,
            # microsecond[, tzinfo]]]]])
            return Timestamp(datetime(ts_input, freq, tz, unit or 0,
                                      year or 0, month or 0, day or 0,
-                                      hour), tz=hour)
+                                      hour), nanosecond=minute, tz=hour)


this doesn't seem right

I tested over these two cases in test_constructor_nanosecond that would hit this path:

Timestamp(2000, 1, 1, 0, 0, 0, 0, None, 1) Timestamp(2000, 1, 1, 0, 0, 0, 0, pytz.UTC, 1)

make your test
2000, 1, 2, 3, 4, 5, 6

jreback · 2018-02-25T16:27:28Z

pandas/_libs/tslibs/timestamps.pyx


        if tzinfo is not None:
            # User passed tzinfo instead of tz; avoid silently ignoring
            tz, tzinfo = tzinfo, None

-        ts = convert_to_tsobject(ts_input, tz, unit, 0, 0)
+        ts = convert_to_tsobject(ts_input, tz, unit, 0, 0, nanosecond or 0)


I agree here, the nanoscecond kw must only be used when kwargs are passed

jreback · 2018-02-25T16:27:57Z

pandas/_libs/tslibs/timestamps.pyx

@@ -423,7 +423,7 @@ class Timestamp(_Timestamp):
        example, 's' means seconds and 'ms' means milliseconds.
    year, month, day : int
        .. versionadded:: 0.19.0
-    hour, minute, second, microsecond : int, optional, default 0
+    hour, minute, second, microsecond, nanosecond : int, optional, default 0


add that nanosecond is in 0.23

jreback · 2018-02-25T16:28:21Z

doc/source/whatsnew/v0.23.0.txt

@@ -577,6 +577,7 @@ Datetimelike API Changes
 - Operations between a :class:`Series` with dtype ``dtype='datetime64[ns]'`` and a :class:`PeriodIndex` will correctly raises ``TypeError`` (:issue:`18850`)
 - Subtraction of :class:`Series` with timezone-aware ``dtype='datetime64[ns]'`` with mis-matched timezones will raise ``TypeError`` instead of ``ValueError`` (:issue:`18817`)
 - :func:`pandas.merge` provides a more informative error message when trying to merge on timezone-aware and timezone-naive columns (:issue:`15800`)
+- :class:`Timestamp` constructor now accepts a `nanosecond` keyword or positional argument (:issue:`18898`)


double backticks on nanosecond

jreback · 2018-02-25T16:28:44Z

pandas/tests/scalar/timestamp/test_timestamp.py

@@ -385,6 +385,18 @@ def test_constructor_fromordinal(self):
        ts = Timestamp.fromordinal(dt_tz.toordinal(), tz='US/Eastern')
        assert ts.to_pydatetime() == dt_tz

+    @pytest.mark.parametrize('result', [


test the string case as you have a above, which should raise a ValueError

jreback

pls run the asv's for Timestamp, I suspect they may slow down slightly, but want to see how much

jreback · 2018-02-25T22:55:44Z

pandas/_libs/tslibs/timestamps.pyx

@@ -427,6 +427,8 @@ class Timestamp(_Timestamp):
        .. versionadded:: 0.19.0
    tzinfo : datetime.tzinfo, optional, default None
        .. versionadded:: 0.19.0


let's put this before tzinfo

jreback · 2018-02-25T22:55:54Z

pandas/_libs/tslibs/timestamps.pyx

@@ -556,7 +558,7 @@ class Timestamp(_Timestamp):
                object freq=None, tz=None, unit=None,
                year=None, month=None, day=None,
                hour=None, minute=None, second=None, microsecond=None,
-                tzinfo=None):


jreback · 2018-02-25T22:56:39Z

pandas/_libs/tslibs/timestamps.pyx

+        if is_string_object(ts_input):
+            # User passed a date string to parse.
+            # Check that the user didn't also pass a date attribute kwarg.
+            date_attrs = [year, month, day, hour, minute, second, microsecond,


make this a class attr, _date_attributes

worth looking into: can class attributes be made readonly? wouldn't want an unwitting user to change this.

jreback · 2018-02-25T22:59:09Z

pandas/_libs/tslibs/timestamps.pyx

        elif is_integer_object(freq):
            # User passed positional arguments:
            # Timestamp(year, month, day[, hour[, minute[, second[,
            # microsecond[, tzinfo]]]]])
            return Timestamp(datetime(ts_input, freq, tz, unit or 0,
                                      year or 0, month or 0, day or 0,
-                                      hour), tz=hour)
+                                      hour), nanosecond=minute, tz=hour)


make your test
2000, 1, 2, 3, 4, 5, 6

mroeschke · 2018-02-26T04:59:46Z

Unfortunately I recently switched to a new environment (Ubuntu app on Windows) and am having some trouble running asv continuous (conda related setup issue I think). Here were some %timeits I was able to run in the meantime.

This Branch 

In [1]: from pandas import *

In [2]: from datetime import *

In [3]: %timeit Timestamp('2017-08-25 08:16:14')
2.6 µs ± 89.8 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)

In [4]: %timeit Timestamp(datetime(2000, 1, 2, 3, 4, 5, 6))
1.67 µs ± 37.6 ns per loop (mean ± std. dev. of 7 runs, 1000000 loops each)

In [6]: %timeit Timestamp(year=2000, month=1, day=2, hour=3, minute=4, second=5, microsecond=6)
3.05 µs ± 88.7 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)

In [9]: import pytz

In [10]: %timeit Timestamp(2000, 1, 2, 3, 4, 5, 6, 1, pytz.UTC)
3.32 µs ± 130 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)

Master

In [1]: import pytz

In [2]: from pandas import *

In [3]: from datetime import *

In [4]: %timeit Timestamp('2017-08-25 08:16:14')
2.48 µs ± 60.6 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)

In [5]: %timeit Timestamp(datetime(2000, 1, 2, 3, 4, 5, 6))
2.08 µs ± 44.3 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)

In [6]: %timeit Timestamp(year=2000, month=1, day=2, hour=3, minute=4, second=5, microsecond=6)
3.57 µs ± 84.1 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)

In [8]: %timeit Timestamp(2000, 1, 2, 3, 4, 5, 6, pytz.UTC)
3.38 µs ± 57 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)

Add additional test Add gh issue number in test Don't pass nanosecond when user passes datetime.date Address review Reorg params, change test, add attribute

jreback

a couple of lint issues, otherwise lgtm. ping on green.

jreback · 2018-02-27T11:19:51Z

pandas/_libs/tslibs/timestamps.pyx

+        if is_string_object(ts_input):
+            # User passed a date string to parse.
+            # Check that the user didn't also pass a date attribute kwarg.
+            #date_attrs = [year, month, day, hour, minute, second, microsecond,


you can remove the date_attrs comment its clear from the code

mroeschke · 2018-02-28T17:02:43Z

Ping, all green

jreback · 2018-03-01T01:32:31Z

thanks @mroeschke keep em coming!

@TomAugspurger

commit df2e361 Author: Jeff Reback <jeff@reback.net> Date: Sun Mar 11 18:33:25 2018 -0400 LINT: fixing commit f1c0b7c Author: David Polo <delkk0@users.noreply.github.com> Date: Sun Mar 11 22:54:27 2018 +0100 DOC: Improved the docstring of pandas.plotting._core.FramePlotMethods… (pandas-dev#20157) * DOC: Improved the docstring of pandas.plotting._core.FramePlotMethods.barh() - Added examples section - Added extended summary - Added argument explanation * DOC: Improved the docstring of pandas.plotting._core.FramePlotMethods.barh() - Correcting PR comments * DOC: Improved the docstring of pandas.plotting._core.FramePlotMethods.barh() - Adding defaults for variables. * Update reference commit 0780193 Author: Jonas Schulze <jonas.schulze7@t-online.de> Date: Sun Mar 11 22:37:37 2018 +0100 DOC: update the pandas.DataFrame.plot.density docstring (pandas-dev#20236) * DOC: update the pandas.DataFrame.plot.kde and pandas.Series.plot.kde docstrings Unfortunately, I was not able to compute a kernel estimate of a two-dimensional random variable. Hence, the example is more of an analysis of some independent data series. * DOC: extract similarities of kde docstrings The `DataFrame.plot.kde` and `Series.plot.kde` now use a common docstring, for which the differences are inserted. commit 2718984 Author: Cihan Ceyhan <chncyhn@gmail.com> Date: Sun Mar 11 21:48:08 2018 +0100 DOC: Update the pandas.Series.dt.round/floor/ceil docstrings (pandas-dev#20187) * DOC: Update the pandas.Series.dt.round/floor/ceil docstrings * DOC: review points fixed. * Add series commit 0d86742 Author: Antonio Molina <aydevosotros@gmail.com> Date: Sun Mar 11 18:57:37 2018 +0100 DOC: Improved pandas.plotting.bootstrap_plot docstring (pandas-dev#20166) * Improved documentation on bootstrap_plot * Improved documentation on bootstrap_plot * Doc bootstrap_plot: Fixed some comments on pull requests * Added reference to wikipedia * Changed kwds for **kwds * Removed ** from kwds becuase of validation iuses * Fixed forgotten break line. I think that the kwds paramater now fits what expected @TomAugspurger. If not, sorry and indicate how it should be * Fixed warnings on compilation * Moved reference to extended description commit a2910ad Author: András Novoszáth <nocibambi@gmail.com> Date: Sun Mar 11 18:56:01 2018 +0100 DOC: update the Index.get_values docstring (pandas-dev#20231) * DOC: update the Index.get_values docstring * Corrections * Corrected extended summary and quotes * Correcting spaces, extended summary, multiIndex example * See also correction * Multi ndim commit afa6c42 Author: Marc <mlafore05@gmail.com> Date: Sun Mar 11 10:42:35 2018 -0400 DOC: update the pandas.DataFrame.all docstring (pandas-dev#20216) commit a44bae3 Author: Victor Villas <villasv@outlook.com> Date: Sun Mar 11 11:41:12 2018 -0300 DOC: update the Series.view docstring (pandas-dev#20220) commit 233103f Author: David Adrián Cañones Castellano <davidarcano@gmail.com> Date: Sun Mar 11 15:40:02 2018 +0100 DOC: update the docstring of pandas.DataFrame.from_dict (pandas-dev#20259) commit 62bddec Author: csfarkas <csaba.farkas95@gmail.com> Date: Sun Mar 11 15:33:54 2018 +0100 DOC: add docstring for Index.get_duplicates (pandas-dev#20223) commit 8c77238 Author: adatasetaday <32177771+adatasetaday@users.noreply.github.com> Date: Sun Mar 11 10:17:05 2018 -0400 Docstring pandas.series.diff (pandas-dev#20238) commit 4271757 Author: Aly Sivji <4369343+alysivji@users.noreply.github.com> Date: Sun Mar 11 08:51:25 2018 -0500 DOC: update `pandas/core/ops.py` docstring template to accept examples (pandas-dev#20246) commit 080ef0c Author: akosel <aaronjkosel@gmail.com> Date: Sun Mar 11 12:43:10 2018 +0000 DOC: update the DataFrame.iat[] docstring (pandas-dev#20219) * DOC: update the DataFrame.iat[] docstring * Update based on PR comments * Update based on PR comments * Singular not plural * Update to account for use with Series. Add example using Series. * Update indexing.py * PEP8 commit 302fda4 Author: adatasetaday <32177771+adatasetaday@users.noreply.github.com> Date: Sun Mar 11 08:36:21 2018 -0400 DOC: update the pandas.DataFrame.diff docstring (pandas-dev#20227) * DOC: update the pandas.DataFrame.diff docstring * DOC: update the pandas.DataFrame.diff docstring * DOC: update the pandas.DataFrame.diff docstring * DOC: update the pandas.DataFrame.diff docstring * DOC: update the pandas.DataFrame.diff docstring * DOC: update the pandas.DataFrame.diff docstring * DOC: update the pandas.DataFrame.diff docstring * DOC: update the pandas.DataFrame.diff docstring * DOC: update the pandas.DataFrame.diff docstring * Cleanup commit c791a84 Author: Pietro Battiston <me@pietrobattiston.it> Date: Sun Mar 11 13:07:01 2018 +0100 DOC: pd.core.window.Expanding.kurt docstring (split from pd.core.Rolling.kurt) (pandas-dev#20064) commit b3d6ce6 Author: Nipun Sadvilkar <nipunsadvilkar@gmail.com> Date: Sun Mar 11 17:29:33 2018 +0530 DOC: update the pandas.date_range() docstring (pandas-dev#20143) * DOC: Improved the docstring of pandas.date_range() * Change date strings to iso format * Removed import pands in Examples docstring * Add See Also Docstring * Update datetimes.py * Doctests commit 6d7272a Author: Samuel Sinayoko <samuelsinayoko@bmlltech.com> Date: Sun Mar 11 11:58:09 2018 +0000 DOC: update DataFrame.to_records (pandas-dev#20191) * Update to_records docstring. - Minor changes (missing dots, newlines) to make tests pass. - More examples. * Fix html docs. Missing newlines. * Reword datetime type information. * flake8 errors * Fix typo (duplicated type) * Remove unwanted blank line after Examples. * Fix doctests. ``` (pandas_dev) sinayoks@landade:~/dev/pandas/ $ pytest --doctest-modules pandas/core/frame.py -k to_record ========================================================================================== test session starts ========================================================================================== platform darwin -- Python 3.6.4, pytest-3.4.2, py-1.5.2, pluggy-0.6.0 rootdir: /Users/sinayoks/dev/pandas, inifile: setup.cfg plugins: xdist-1.22.1, forked-0.2, cov-2.5.1 collected 43 items pandas/core/frame.py . [100%] ========================================================================================== 42 tests deselected ========================================================================================== ``` * Few more changes commit 636335a Author: Gabriel de Maeztu <gabriel.maeztu@gmail.com> Date: Sun Mar 11 12:56:48 2018 +0100 DOC: Improved the docstring of pandas.plotting.radviz (pandas-dev#20169) commit fbebc7f Author: jen w <j.e.weiss@gmail.com> Date: Sun Mar 11 06:50:54 2018 -0500 DOC: Update pandas.DataFrame.tail docstring (pandas-dev#20225) commit c2864d7 Author: Stephen Childs <sechilds@gmail.com> Date: Sun Mar 11 07:50:39 2018 -0400 DOC: update the DataFrame.cov docstring (pandas-dev#20245) * DOC: Revise docstring of DataFrame cov method Update the docstring with some examples from elsewhere in the pandas documentation. Some of the examples use randomly generated time series because we need to get covariance between long series. Used a random seed to ensure that the results are the same each time. * DOC: Fix See Also and min_periods explanation. Responding to comments on PR. See also section will link properly and number of periods explanation clearer. commit 90e31b9 Author: jen w <j.e.weiss@gmail.com> Date: Sun Mar 11 06:50:18 2018 -0500 DOC: update pandas.DataFrame.head docstring (pandas-dev#20262) commit fb556ed Author: Israel Saeta Pérez <dukebody@gmail.com> Date: Sat Mar 10 22:33:42 2018 +0100 DOC: Improve pandas.Series.plot.kde docstring and kwargs rewording for whole file (pandas-dev#20041) commit c3d491a Author: Andy R. Terrel <andy.terrel@gmail.com> Date: Sat Mar 10 11:48:13 2018 -0800 DOC: update the DataFrame.head() docstring (pandas-dev#20206) commit dd7f567 Author: DataOmbudsman <DataOmbudsman@users.noreply.github.com> Date: Sat Mar 10 20:15:48 2018 +0100 DOC: update the Index.shift docstring (pandas-dev#20192) * DOC: updating docstring of Index.shift * Add See Also section to shift * Update link to Series.shift commit 5b0caf4 Author: Eric O. LEBIGOT (EOL) <lebigot@users.noreply.github.com> Date: Sat Mar 10 17:32:20 2018 +0100 DOC: update the Series.memory_usage() docstring (pandas-dev#20086) commit 9fb7ac9 Author: Carol Willing <carolcode@willingconsulting.com> Date: Sat Mar 10 08:28:54 2018 -0800 DOC: Edit contributing to docs section (pandas-dev#20190) commit d8181a5 Author: DaanVanHauwermeiren <DaanVanHauwermeiren@users.noreply.github.com> Date: Sat Mar 10 17:25:20 2018 +0100 DOC: update the Series.isin docstring (pandas-dev#20175) commit ec631ce Author: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> Date: Sat Mar 10 17:12:41 2018 +0100 DOC: update the pandas.Series.tail docstring (pandas-dev#20176) commit e5e4ae9 Author: DaanVanHauwermeiren <DaanVanHauwermeiren@users.noreply.github.com> Date: Sat Mar 10 16:41:58 2018 +0100 DOC: update the pandas.Index.drop_duplicates and pandas.Series.drop_duplicates docstring (pandas-dev#20114) commit d7bcb22 Author: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> Date: Sat Mar 10 15:49:31 2018 +0100 DOC: update the MultiIndex.swaplevel docstring (pandas-dev#20105) commit 8497029 Author: Gjelt <math-and-data@users.noreply.github.com> Date: Sat Mar 10 15:41:17 2018 +0100 DOC: Improved the docstring of pandas.DataFrame.values (pandas-dev#20065) commit 840d432 Author: Jordi Contestí <25779507+jcontesti@users.noreply.github.com> Date: Sat Mar 10 13:24:35 2018 +0100 DOC: Improved the docstring of Series.str.findall (pandas-dev#19982) commit 2a0d23b Author: Jeff Reback <jeff@reback.net> Date: Sat Mar 10 06:54:19 2018 -0500 DOC: lint commit bf0dcb5 Author: Kate Surta <kate.surta@gmail.com> Date: Sat Mar 10 14:42:52 2018 +0300 BUG: Check for wrong arguments in index subclasses constructors (pandas-dev#20017) commit 4131149 Author: Stijn Van Hoey <stijnvanhoey@gmail.com> Date: Sat Mar 10 10:15:41 2018 +0100 DOC: Extend docstring pandas core index to_frame method (pandas-dev#20036) commit 52cffa3 Author: William Ayd <william.ayd@icloud.com> Date: Fri Mar 9 18:06:43 2018 -0800 Cythonized GroupBy pct_change (pandas-dev#19919) commit da6f827 Author: William Ayd <william.ayd@icloud.com> Date: Fri Mar 9 18:03:50 2018 -0800 Refactored GroupBy ASVs (pandas-dev#20043) commit bd31f71 Author: William Ayd <william.ayd@icloud.com> Date: Fri Mar 9 17:53:34 2018 -0800 Added 'displayed_only' option to 'read_html' (pandas-dev#20047) commit ed96567 Author: Ksenia <bobrovaksenia@gmail.com> Date: Sat Mar 10 02:40:10 2018 +0100 TST: series/indexing tests parametrization + moving test methods (pandas-dev#20059) commit 7c14e4f Author: Kyle Barron <kylebarron2@gmail.com> Date: Fri Mar 9 11:31:14 2018 -0500 DOC: Add syntax highlighting to SAS code blocks in comparison_with_sas.rst (pandas-dev#20080) * Add syntax highlighting to SAS code blocks * Fix typo commit 731d971 Author: Matthew Roeschke <emailformattr@gmail.com> Date: Fri Mar 9 03:30:22 2018 -0800 Fix typo in apply.py (pandas-dev#20058) commit cc1b934 Author: Matthew Roeschke <emailformattr@gmail.com> Date: Fri Mar 9 03:13:50 2018 -0800 BUG: Retain timezone dtype with cut and qcut (pandas-dev#19890) commit c730d08 Author: William Ayd <william.ayd@icloud.com> Date: Fri Mar 9 02:37:27 2018 -0800 DOC: Update Kurt Docstr (pandas-dev#20044) commit 9119d07 Author: Joris Van den Bossche <jorisvandenbossche@gmail.com> Date: Fri Mar 9 10:03:44 2018 +0100 Temporary github PR template for sprint (pandas-dev#20055) commit 747501a Author: Aly Sivji <4369343+alysivji@users.noreply.github.com> Date: Fri Mar 9 02:19:59 2018 -0600 DOC: Improve docstring for pandas.Index.repeat (pandas-dev#19985) commit 1d73cf3 Author: Rouz Azari <rouzazari@users.noreply.github.com> Date: Thu Mar 8 16:54:53 2018 -0800 BUG: Dense ranking with percent now uses 100% basis (pandas-dev#15639) commit f9fd540 Author: William Ayd <william.ayd@icloud.com> Date: Thu Mar 8 16:36:23 2018 -0800 Added flake8 to DEV requirements (pandas-dev#20063) commit b669112 Author: Joris Van den Bossche <jorisvandenbossche@gmail.com> Date: Thu Mar 8 14:09:12 2018 +0100 DOC: require returns section in validation script (pandas-dev#19994) commit 024d8b4 Author: Jeff Reback <jeff@reback.net> Date: Thu Mar 8 07:08:57 2018 -0500 TST: xfail test_time on py2 & mpl 1.4.3 (pandas-dev#20053) commit b85f6c1 Author: Marc Garcia <garcia.marc@gmail.com> Date: Thu Mar 8 11:07:08 2018 +0000 DOC: update docstring validation script + replace api coverage script (pandas-dev#20025) * Improvments to validate_docstrings script: adding sections to summary, validating type and description of parameters * DOC: Improvements to validate docstring script (added api_coverage functionality, sections in csv and extra validations) commit 9273bf5 Author: Joris Van den Bossche <jorisvandenbossche@gmail.com> Date: Thu Mar 8 11:14:05 2018 +0100 DOC/CI: temp pin matplotlib for doc build (pandas-dev#20045) commit 63ce781 Author: Jeff Reback <jeff@reback.net> Date: Wed Mar 7 17:01:38 2018 -0500 TST: xfail mpl 2.2 tests xref pandas-dev#20031 commit 7c7bd56 Author: Daniel Frank <danfrankj@gmail.com> Date: Wed Mar 7 13:54:46 2018 -0800 enable multivalues insert (pandas-dev#19664) commit f33e84c Author: Ksenia <bobrovaksenia@gmail.com> Date: Wed Mar 7 22:09:42 2018 +0100 Moving tests in series/indexing to fixtures (pandas-dev#20014.1) (pandas-dev#20034) commit 2532a49 Author: Liam3851 <david.krych@gmail.com> Date: Wed Mar 7 13:04:22 2018 -0500 BUG: Fixes to msgpack support. (pandas-dev#19975) commit fd010de Author: Guilherme Beltramini <guilherme.beltramini@nubank.com.br> Date: Wed Mar 7 11:33:09 2018 -0300 to_sql also accepts Series (pandas-dev#20004) commit 8d462ed Author: Paul Reidy <paul_reidy@outlook.com> Date: Wed Mar 7 14:32:12 2018 +0000 EHN: Implement method argument for DataFrame.replace (pandas-dev#19894) commit d14fae8 Author: jbrockmendel <jbrockmendel@gmail.com> Date: Wed Mar 7 06:19:21 2018 -0800 cleanup ops (pandas-dev#19972) commit 776f2be Author: William Ayd <william.ayd@icloud.com> Date: Wed Mar 7 05:59:39 2018 -0800 Added .pytest_cache to gitignore (pandas-dev#20021) commit 460941f Author: jschendel <jschendel@users.noreply.github.com> Date: Wed Mar 7 06:57:51 2018 -0700 Fix typos in test_interval_new (pandas-dev#20026) commit 5782ab8 Author: Joris Van den Bossche <jorisvandenbossche@gmail.com> Date: Wed Mar 7 14:57:17 2018 +0100 DOC: enable matplotlib plot_directive to include figures in docstrings (pandas-dev#20015) commit dd2b224 Author: DataOmbudsman <DataOmbudsman@users.noreply.github.com> Date: Wed Mar 7 14:56:49 2018 +0100 DOC: updating docstring of Index.shift (pandas-dev#19996) commit 09c416c Author: William Ayd <william.ayd@icloud.com> Date: Wed Mar 7 05:56:16 2018 -0800 DOC: Updated kurt docstring (for pandas sprint) (pandas-dev#19999) commit ad15f80 Author: Kate Surta <kate.surta@gmail.com> Date: Wed Mar 7 16:55:48 2018 +0300 TST: Fix wrong argument in TestDataFrameAlterAxes.test_set_index_dst (pandas-dev#20019) commit f6ee9ac Author: Jeff Reback <jeff@reback.net> Date: Wed Mar 7 08:55:33 2018 -0500 TST: xfail clip tests under numpy-dev (pandas-dev#20035) xref pandas-dev#19976 commit 397e296 Author: Jeff Reback <jeff@reback.net> Date: Wed Mar 7 08:15:49 2018 -0500 TST: xfail some tests for mpl 2.2 compat (pandas-dev#20033) xref pandas-dev#20031 commit 56939b4 Author: luzpaz <luzpaz@users.noreply.github.com> Date: Wed Mar 7 06:10:39 2018 -0500 DOC: misc typos (pandas-dev#20029) commit 01b91c2 Author: alinde1 <32714875+alinde1@users.noreply.github.com> Date: Tue Mar 6 22:47:45 2018 +0100 DOC: is confusing for ddof parameter of sem, var and std functions (pandas-dev#19986) commit db82165 Author: Joris Van den Bossche <jorisvandenbossche@gmail.com> Date: Tue Mar 6 22:42:41 2018 +0100 CLN/DOC: cache_readonly: remove allow_setting + preserve docstring (pandas-dev#19991) commit e02f737 Author: Tom Augspurger <TomAugspurger@users.noreply.github.com> Date: Tue Mar 6 09:38:32 2018 -0600 DOC: add doc on ExtensionArray and extending pandas (pandas-dev#19936) commit 0ca77b3 Author: jbrockmendel <jbrockmendel@gmail.com> Date: Tue Mar 6 04:27:21 2018 -0800 Datetimelike add/sub catch cases more explicitly, tests (pandas-dev#19912) commit 0038bad Author: Matthew Roeschke <emailformattr@gmail.com> Date: Tue Mar 6 04:25:55 2018 -0800 month_name/day_name warnings followup (pandas-dev#20010) commit fd63c90 Author: Ksenia <bobrovaksenia@gmail.com> Date: Tue Mar 6 13:25:37 2018 +0100 TST: split series/test_indexing.py (pandas-dev#18614) (pandas-dev#20006) commit 6366bf0 Author: Jeff Reback <jeff@reback.net> Date: Tue Mar 6 07:25:17 2018 -0500 TST: clean deprecation warnings for xref pandas-dev#19980 (pandas-dev#20013) xfail some mpl > 2.1.2 tests commit fe61299 Author: William Ayd <william.ayd@icloud.com> Date: Tue Mar 6 00:30:13 2018 -0800 DOC: fixed dynamic import mechanics of make.py (pandas-dev#20005) commit 8a084eb Author: Grant Smith <grantsmith@gmail.com> Date: Tue Mar 6 03:29:26 2018 -0500 CLN: deprecate the pandas.tseries.plotting.tsplot function (GH18627) (pandas-dev#19980) commit aedbd94 Author: Jeff Reback <jeff@reback.net> Date: Mon Mar 5 06:36:41 2018 -0500 TST: text correction, xref pandas-dev#19987 commit cbffd19 Author: Bhavesh Poddar <bhavesh13103507@gmail.com> Date: Mon Mar 5 06:34:59 2018 -0500 fixed pytest deprecation warning (pandas-dev#19987) commit 058a16c Author: Matthew Roeschke <emailformattr@gmail.com> Date: Mon Mar 5 03:23:49 2018 -0800 CLN: Use generators in builtin functions (pandas-dev#19989) commit 607910b Author: Matthew Roeschke <emailformattr@gmail.com> Date: Sun Mar 4 12:15:37 2018 -0800 Add month names (pandas-dev#18164) commit 2fad756 Author: jbrockmendel <jbrockmendel@gmail.com> Date: Sun Mar 4 12:00:39 2018 -0800 transition period_helper to use pandas_datetimestruct (pandas-dev#19918) commit 53606ff Author: Liam3851 <david.krych@gmail.com> Date: Sun Mar 4 14:58:22 2018 -0500 BUG: Compat for pre-0.20 TimedeltaIndex and Float64Index pickles pandas-dev#19939 (pandas-dev#19943) commit 0bfb61b Author: Joris Van den Bossche <jorisvandenbossche@gmail.com> Date: Fri Mar 2 22:35:45 2018 +0100 DOC: small updates to make.py script (pandas-dev#19951) * enable passing verbosity flag to sphinx * alias api for api.rst commit d1f3689 Author: Joris Van den Bossche <jorisvandenbossche@gmail.com> Date: Fri Mar 2 22:33:48 2018 +0100 DOC: fix some sphinx syntax warnings (pandas-dev#19962) commit 49f09cc Author: Tom Augspurger <TomAugspurger@users.noreply.github.com> Date: Fri Mar 2 15:20:28 2018 -0600 API: Added ExtensionArray constructor from scalars (pandas-dev#19913) commit d30d165 Author: Joris Van den Bossche <jorisvandenbossche@gmail.com> Date: Fri Mar 2 22:18:10 2018 +0100 DOC: update docstring validation script (pandas-dev#19960) commit a7a7f8c Author: Joris Van den Bossche <jorisvandenbossche@gmail.com> Date: Fri Mar 2 13:49:59 2018 +0100 DOC: clarify version of ActivePython that includes pandas (pandas-dev#19964) commit b167483 Author: Gina <Dr-G@users.noreply.github.com> Date: Fri Mar 2 05:33:49 2018 -0600 DOC: update install.rst to include ActivePython distribution (pandas-dev#19908) commit e6c7dea Author: topper-123 <terji78@gmail.com> Date: Fri Mar 2 11:19:07 2018 +0000 ENH: Let initialisation from dicts use insertion order for python >= 3.6 (part III) (pandas-dev#19884) commit d615f86 Author: Marc Garcia <garcia.marc@gmail.com> Date: Fri Mar 2 09:39:45 2018 +0000 DOC: Adding script to validate docstrings, and generate list of all functions/methods with state (pandas-dev#19898) commit 5f271eb Author: Yian <yian.shang@gmail.com> Date: Fri Mar 2 00:13:58 2018 +0100 BUG: Adding skipna as an option to groupby cumsum and cumprod (pandas-dev#19914) commit 072545d Author: David C Hall <davidchall@users.noreply.github.com> Date: Thu Mar 1 15:06:20 2018 -0800 ENH: Add option to disable MathJax (pandas-dev#19824). (pandas-dev#19856) commit d44a6ec Author: Yian <yian.shang@gmail.com> Date: Fri Mar 2 00:02:31 2018 +0100 Making to_datetime('today') and Timestamp('today') consistent (pandas-dev#19937) commit 87fefe2 Author: jbrockmendel <jbrockmendel@gmail.com> Date: Thu Mar 1 14:54:42 2018 -0800 dispatch Series[datetime64] comparison ops to DatetimeIndex (pandas-dev#19800) commit 9242248 Author: Matthew Roeschke <emailformattr@gmail.com> Date: Thu Mar 1 14:50:35 2018 -0800 BUG: DataFrame.diff(axis=0) with DatetimeTZ data (pandas-dev#19773) commit c5a1ef1 Author: Joris Van den Bossche <jorisvandenbossche@gmail.com> Date: Thu Mar 1 22:48:39 2018 +0100 DOC: remove empty attribute/method lists from class docstrings html page (pandas-dev#19949) commit 9958ce6 Author: jschendel <jschendel@users.noreply.github.com> Date: Thu Mar 1 04:14:19 2018 -0700 BUG: Preserve column metadata with DataFrame.astype (pandas-dev#19948) commit 3b4eb8d Author: Joris Van den Bossche <jorisvandenbossche@gmail.com> Date: Thu Mar 1 12:12:35 2018 +0100 CLN: remove redundant clean_fill_method calls (pandas-dev#19947) commit c8859b5 Author: Joris Van den Bossche <jorisvandenbossche@gmail.com> Date: Thu Mar 1 10:35:05 2018 +0100 DOC: script to build single docstring page (pandas-dev#19840) commit 52559f5 Author: Matthew Roeschke <emailformattr@gmail.com> Date: Wed Feb 28 17:32:24 2018 -0800 ENH: Allow Timestamp to accept Nanosecond argument (pandas-dev#19889) commit 4a27697 Author: William Ayd <william.ayd@icloud.com> Date: Wed Feb 28 17:30:18 2018 -0800 Cythonized GroupBy any (pandas-dev#19722) commit 96b8bb1 Author: jschendel <jschendel@users.noreply.github.com> Date: Wed Feb 28 18:07:15 2018 -0700 ENH: Implement DataFrame.astype('category') (pandas-dev#18099) commit 6ef4be3 Author: Liam3851 <david.krych@gmail.com> Date: Wed Feb 28 06:14:11 2018 -0500 ENH: Allow literal (non-regex) replacement using .str.replace pandas-dev#16808 (pandas-dev#19584) commit 318a287 Author: README Bot <35302948+codetriage-readme-bot@users.noreply.github.com> Date: Wed Feb 28 05:07:28 2018 -0600 Add CodeTriage badge to pandas-dev/pandas (pandas-dev#19928) Adds a badge showing the number of people helping this repo on CodeTriage. commit 14a38a6 Author: Chris Catalfo <ccatalfo@users.noreply.github.com> Date: Wed Feb 28 03:14:23 2018 -0500 DOC: fixes pipe example in basics.rst due to statsmodel changes (pandas-dev#19923) commit dfe9d4a Author: Phil Ngo <ngo.phil@gmail.com> Date: Wed Feb 28 00:05:56 2018 -0800 DOC: fix Series.reset_index example (pandas-dev#19930) commit 9bdc5c8 Author: William Ayd <william.ayd@icloud.com> Date: Tue Feb 27 16:16:48 2018 -0800 Consistent Timedelta Writing for all Excel Engines (pandas-dev#19921) commit 61211a8 Author: jbrockmendel <jbrockmendel@gmail.com> Date: Tue Feb 27 16:11:47 2018 -0800 Assorted _libs cleanups (pandas-dev#19887)

jbrockmendel reviewed Feb 25, 2018

View reviewed changes

jreback requested changes Feb 25, 2018

View reviewed changes

jreback added Datetime Datetime data dtype API Design labels Feb 25, 2018

mroeschke force-pushed the nanoseconds_timestamp branch from 1c6e23d to 1fa84d8 Compare February 25, 2018 22:09

jreback requested changes Feb 25, 2018

View reviewed changes

mroeschke force-pushed the nanoseconds_timestamp branch from 1fa84d8 to b8f836c Compare February 26, 2018 04:31

ENH: Allow Timestamp to accept Nanosecond argument

55c10be

Add additional test Add gh issue number in test Don't pass nanosecond when user passes datetime.date Address review Reorg params, change test, add attribute

mroeschke force-pushed the nanoseconds_timestamp branch from b8f836c to 55c10be Compare February 26, 2018 23:14

jreback added this to the 0.23.0 milestone Feb 27, 2018

jreback requested changes Feb 27, 2018

View reviewed changes

Fix lint

c81ec57

jorisvandenbossche mentioned this pull request Feb 28, 2018

ENH: Timestamp constructor does not accept nanosecond arg #18898

Closed

jreback approved these changes Mar 1, 2018

View reviewed changes

jreback merged commit 52559f5 into pandas-dev:master Mar 1, 2018

mroeschke deleted the nanoseconds_timestamp branch March 1, 2018 02:05

jbrockmendel mentioned this pull request Jun 12, 2018

tslibs TODO list #17652

Closed

59 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ENH: Allow Timestamp to accept Nanosecond argument #19889

ENH: Allow Timestamp to accept Nanosecond argument #19889

mroeschke commented Feb 25, 2018

jbrockmendel Feb 25, 2018

mroeschke Feb 25, 2018

jbrockmendel Feb 25, 2018

mroeschke Feb 25, 2018

jreback Feb 25, 2018

codecov bot commented Feb 25, 2018

codecov bot commented Feb 25, 2018 •

edited

Loading

jreback Feb 25, 2018

mroeschke Feb 25, 2018

jreback Feb 25, 2018

jreback Feb 25, 2018

jreback Feb 25, 2018

jreback Feb 25, 2018

jreback Feb 25, 2018

jreback left a comment

jreback Feb 25, 2018

jreback Feb 25, 2018

jreback Feb 25, 2018

jbrockmendel Feb 26, 2018

jreback Feb 25, 2018

mroeschke commented Feb 26, 2018

jreback left a comment

jreback Feb 27, 2018

mroeschke commented Feb 28, 2018

jreback commented Mar 1, 2018

ENH: Allow Timestamp to accept Nanosecond argument #19889

ENH: Allow Timestamp to accept Nanosecond argument #19889

Conversation

mroeschke commented Feb 25, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Feb 25, 2018

Codecov Report

codecov bot commented Feb 25, 2018 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jreback left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mroeschke commented Feb 26, 2018

jreback left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mroeschke commented Feb 28, 2018

jreback commented Mar 1, 2018

codecov bot commented Feb 25, 2018 •

edited

Loading