CLN/DEPR: removed deprecated as_indexer arg from str.match() #22626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @HyunTruth! Thanks for submitting the PR.
|
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #22626 +/- ##
==========================================
- Coverage 92.04% 92.04% -0.01%
==========================================
Files 169 169
Lines 50782 50778 -4
==========================================
- Hits 46744 46740 -4
Misses 4038 4038
Continue to review full report at Codecov.
|
jreback
requested changes
Sep 7, 2018
doc/source/whatsnew/v0.24.0.txt
Outdated
| @@ -528,7 +528,7 @@ Removal of prior version deprecations/changes | |||
| - Removal of the previously deprecated module ``pandas.core.datetools`` (:issue:`14105`, :issue:`14094`) | |||
| - Strings passed into :meth:`DataFrame.groupby` that refer to both column and index levels will raise a ``ValueError`` (:issue:`14432`) | |||
| - :meth:`Index.repeat` and :meth:`MultiIndex.repeat` have renamed the ``n`` argument to ``repeats``(:issue:`14645`) | |||
| - | |||
| - Removal of the previously deprecated as_indexer keyword completely from ``str.match()`` (:issue:`22356`,:issue:`6581`) | |||
There was a problem hiding this comment.
can you use double-back ticks here on as_indexer, also use the ref, .e.g :meth:`~Series.str.match`
jorisvandenbossche
approved these changes
Sep 7, 2018
|
Did the small change, thanks a lot @HyunTruth ! |
|
Thanks @jorisvandenbossche! |
aeltanawy
pushed a commit
to aeltanawy/pandas
that referenced
this pull request
Sep 20, 2018
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffThis is the renewal of #22356, as the git got tangled up I re-forked the repo.