DOC: Fix pandas.Series.resample docstring #23197

jmrr · 2018-10-17T11:46:16Z

closes DOC: Fix the docstring of resample in pandas/core/generic.py #22894
tests added / passed:
- ./scripts/validate_docstrings.py pandas.Series.resample
- flake8 --doctests pandas/core/generic.py
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry --> Needed?
Followed pandas docstring conventions and general reST.
Added deprecation directive on some parameters. Had some doubts but after investigation the recommended API changed after v0.18.0 for these parameters.

Please let me know if I can further improve this.

Thanks!

* First iteration over some validation errors on pandas.Series.resample. * Fix multi-line examples issue.

Not too sure they were deprecated from v0.18.0. Need to point this out in the PR.

pep8speaks · 2018-10-17T11:46:19Z

Hello @jmrr! Thanks for submitting the PR.

There are no PEP8 issues in the file pandas/core/generic.py !

datapythonista

Added some comments.

datapythonista · 2018-10-27T09:49:35Z

pandas/core/generic.py

-        to the on or level keyword.
+        series.  Object must have a datetime-like index (``DatetimeIndex``,
+        ``PeriodIndex``, or ``TimedeltaIndex``), or pass datetime-like values
+        to the ``on`` or ``level`` keyword.

        Parameters
        ----------
        rule : string


Can you use the Python types (str instead of string...)

Thanks, done. The module is full of string by the way. Should I create another issue for that? Do these values str, int get picked up by Sphinx?

I think it's better to fix one whole docstring at a time, than fixing a problem in all docstrings.

Sphinx doesn't care about the types, but we try to be consistent, and will start validating the types soon (not sure if validate_docstrings.py already conmplains about these.

Yeah, atomic improvements around each docstring make total sense. Pushing the amendments now.

datapythonista · 2018-10-27T09:50:23Z

pandas/core/generic.py

+
+            .. deprecated:: 0.18.0
+               The new syntax is ``.resample(...).mean()``, or
+               ``.resample(...).apply(<func>)``
        axis : int, optional, default 0


Can you check other docstrings to see how the axis type is usually documented?

Another example is:

apply to each column (``axis=0`` or ``'index'``) or to each row (``axis=1`` or ``'columns'``) or

The problem is that for Series the axis is that along which the operation is computed, which in this case it's always along the rows (aka columnwise).

Maybe a more verbose but informative doc would be

Which axis to use for up- or down-sampling. For ``Series`` this will default to 0, i.e. `along the rows`. Must be ``DatetimeIndex``, ``TimedeltaIndex`` or ``PeriodIndex``.

I have added this tentatively to the PR but let me know if something less verbose would be better.

Sorry I wasn't clear. There is not much standardization of the descriptions, use whatever makes more sense to you. But the used type is somehow standard, that's what I think we should copy from another docstring.

@jmrr can you make this change?

Hi @datapythonista not your fault at all. I somewhat skipped the word type in your request and I thought you meant how axis is usually documented. Regarding the type and values there's no much standardization either. From set_axis() in pandas/core/generic.py I like the following:

{0 or 'index', 1 or 'columns'}, default 0

If we extrapolate this to Series then that line should be:

axis : {0 or 'index'}, default 0

I will make this change now, hope it sounds good.

datapythonista · 2018-10-27T09:51:09Z

pandas/core/generic.py

@@ -7385,18 +7401,22 @@ def resample(self, rule, how=None, axis=0, fill_method=None, closed=None,
            for all frequency offsets except for 'M', 'A', 'Q', 'BM',
            'BA', 'BQ', and 'W' which all have a default of 'right'.
        convention : {'start', 'end', 's', 'e'}


Some default values are missing, like in this case.

datapythonista · 2018-10-27T09:51:52Z

pandas/core/generic.py

-        kind: {'timestamp', 'period'}, optional
+            For ``PeriodIndex`` only, controls whether to use the start or
+            end of ``rule``.
+        kind : {'timestamp', 'period'} optional


missing comma before optional

datapythonista · 2018-10-27T09:52:40Z

pandas/core/generic.py

-                                                        freq='A',
-                                                        periods=2))
+        >>> s = pd.Series([1, 2], index=pd.period_range(
+        ...                                             '2012-01-01',


I'd keep the date in the previous line

datapythonista · 2018-10-27T09:53:26Z

pandas/core/generic.py

@@ -7577,9 +7598,9 @@ def resample(self, rule, how=None, axis=0, fill_method=None, closed=None,

        >>> time = pd.date_range('1/1/2000', periods=5, freq='T')
        >>> df2 = pd.DataFrame(data=10*[range(4)],


pep8 issue, missing spaces around operator.

…issues... (pandas-dev#22894)

codecov · 2018-10-27T14:57:59Z

Codecov Report

Merging #23197 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #23197      +/-   ##
==========================================
- Coverage   92.25%   92.25%   -0.01%     
==========================================
  Files         161      161              
  Lines       51262    51277      +15     
==========================================
+ Hits        47292    47305      +13     
- Misses       3970     3972       +2

Flag	Coverage Δ
#multiple	`90.63% <ø> (-0.01%)`	⬇️
#single	`42.32% <ø> (-0.02%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/generic.py	`96.81% <ø> (ø)`	⬆️
pandas/util/testing.py	`86.71% <0%> (-0.08%)`	⬇️
pandas/core/arrays/datetimelike.py	`95.9% <0%> (-0.03%)`	⬇️
pandas/core/frame.py	`97.03% <0%> (ø)`	⬆️
pandas/io/parquet.py	`84.76% <0%> (+1.25%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efd1844...109e414. Read the comment docs.

datapythonista

Good work, added some comments, mainly to the original code, not your changes.

datapythonista · 2018-11-04T11:02:20Z

pandas/core/generic.py

+
+            .. deprecated:: 0.18.0
+               The new syntax is ``.resample(...).mean()``, or
+               ``.resample(...).apply(<func>)``
        axis : int, optional, default 0


@jmrr can you make this change?

datapythonista · 2018-11-04T11:08:05Z

pandas/core/generic.py

-                                                        freq='A',
-                                                        periods=2))
+        ...                                             freq='A',
+        ...                                             periods=2))
        >>> s
        2012    1
        2013    2


In the following examples, when using resample, it once uses .head() and the other time it shows 12 months. I don't like any of them. I'd use something like resampling a year to quarters, or a quarter to months... So we can show all the data, and it's just few rows that readers can quickly check.

I've created two examples, one sampling a year into quarters using convention='start' and another sampling quarters into months using the convention='end'. If it's too much we can remove one of them.

datapythonista · 2018-11-04T11:11:27Z

pandas/core/generic.py

@@ -7563,7 +7584,8 @@ def resample(self, rule, how=None, axis=0, fill_method=None, closed=None,
        For DataFrame objects, the keyword ``on`` can be used to specify the
        column instead of the index for resampling.

-        >>> df = pd.DataFrame(data=9*[range(4)], columns=['a', 'b', 'c', 'd'])
+        >>> df = pd.DataFrame(data=9 * [range(4)],
+        ...                   columns=['a', 'b', 'c', 'd'])
        >>> df['time'] = pd.date_range('1/1/2000', periods=9, freq='T')
        >>> df.resample('3T', on='time').sum()
                             a  b  c  d


We should show the data before resampling, otherwise it's difficult to see what resample is doing. Also, we can probably have just two columns instead of 4, name them with something meaningful (like price and volume instead of a and b), and create the DataFrame in a nicer way (in a single command, with no range, may be just a dict).

OK, I've revamped this example. Pushing now altogether with the rest of the changes. Agree more meaningful examples make sure everyone understands. Just a bit conscious of being too verbose. But looking forward to your feedback.

pandas/core/generic.py

datapythonista · 2018-11-04T11:12:49Z

pandas/core/generic.py

+        >>> df2 = pd.DataFrame(data=10 * [range(4)],
+        ...                    columns=['a', 'b', 'c', 'd'],
+        ...                    index=pd.MultiIndex.from_product([time, [1, 2]])
+        ...                    )
        >>> df2.resample('3T', level=0).sum()


same comments as in the previous example.

Done, also with a different, more realistic approach. Please let me know your comments. I also struggled a bit with the formatting of long lines, opted for styling lines 7627-7632 using black (also compatible with PEP8) but let me know it breaks consistency and should be reverted to the old style. Pushing now.

… convention examples. (pandas-dev#22894)

…andas-dev#22894)

…er and other cosmetical mods. (pandas-dev#22894)

jmrr · 2018-11-07T13:55:32Z

Thanks for the great feedback @datapythonista. I've pushed some changes as per your comments, I've been a bit creative with some examples, let me know if I went too far :)

datapythonista

Some more comments, and I think we're ready to merge.

datapythonista · 2018-11-09T12:17:15Z

pandas/core/generic.py

+            .. deprecated:: 0.18.0
+               The new syntax is ``.resample(...).mean()``, or
+               ``.resample(...).apply(<func>)``
+        axis : {0 or 'index'}, default 0


methods in generic.py are reused for both in Series and DataFrame. I guess for DataFrame we can also use axis='columns'?

That's right, I wasn't sure, I'll add it. Thinking about it now perhaps we could've added more examples with DataFrame.

datapythonista · 2018-11-09T12:19:05Z

pandas/core/generic.py

+        axis : {0 or 'index'}, default 0
+            Which axis to use for up- or down-sampling. For ``Series`` this
+            will default to 0, i.e. `along the rows`. Must be
+            ``DatetimeIndex``, ``TimedeltaIndex`` or ``PeriodIndex``.


I don't understand the must be. I don't think axis must be DatetimeIndex...

Also, don't use backticks around the "along the rows". Backticks are to tell that it's a reference (to a variable, a function, a class...). We don't use them for text.

I don't understand the must be. I don't think axis must be DatetimeIndex...

I took it from the main function description. As rule must be an offset string which are time-related magnitudes I decided to be explicit here. Also I ran some tests and got TypeError: Only valid with DatetimeIndex, TimedeltaIndex or PeriodIndex.

In fact, following this logic, on should also have that sentence: Must be ``DatetimeIndex``, ``TimedeltaIndex`` or ``PeriodIndex``.

For instance:

>>> df = pd.DataFrame({'price': [10, 11, 9, 13, 14, 18, 17, 19], 'volume': [50, 60, 40, 100, 50, 100, 40, 50]}) >>> df['time'] = pd.date_range('01/01/2018', periods=8, freq='W') >>> df price volume time 0 10 50 2018-01-07 1 11 60 2018-01-14 2 9 40 2018-01-21 3 13 100 2018-01-28 4 14 50 2018-02-04 5 18 100 2018-02-11 6 17 40 2018-02-18 7 19 50 2018-02-25 >>> df.resample('M', on='time').sum() price volume time 2018-01-31 43 250 2018-02-28 68 240

I hope I'm not missing anything here... resample is not a function I've used heavily personally.

Also, don't use backticks around the "along the rows". Backticks are to tell that it's a reference (to a variable, a function, a class...). We don't use them for text.

Slip of keyboard, I meant normal textual quotes ("). Changing.

datapythonista · 2018-11-09T12:20:32Z

pandas/core/generic.py

-        kind: {'timestamp', 'period'}, optional
+        convention : {'start', 'end', 's', 'e'}, default 'start'
+            For ``PeriodIndex`` only, controls whether to use the start or
+            end of ``rule``.


single backticks, in both cases, double backticks are for code (including possible values of variables like NaN). But for classes, variables, parameters... we use single backticks.

Got it, wasn't clear from the docstring docs.

Would None be with double backtick in examples like "default None"?

That's a good question. I think it probably should, but we don't have it anywhere, so let's leave it without backticks in the default for now

datapythonista · 2018-11-09T12:20:47Z

pandas/core/generic.py

+        loffset : timedelta, default None
+            Adjust the resampled time labels.
+        limit : int, default None
+            Maximum size gap when reindexing with ``fill_method``.


datapythonista · 2018-11-09T12:20:55Z

pandas/core/generic.py

            For a MultiIndex, level (name or number) to use for
-            resampling.  Level must be datetime-like.
+            resampling. ``level`` must be datetime-like.


datapythonista · 2018-11-09T12:22:43Z

pandas/core/generic.py

@@ -7422,6 +7443,10 @@ def resample(self, rule, how=None, axis=0, fill_method=None, closed=None,
        To learn more about the offset strings, please see `this link
        <http://pandas.pydata.org/pandas-docs/stable/timeseries.html#offset-aliases>`__.

+        See Also
+        --------
+        groupby : Group by mapping, function, label, or list of labels.


As this is for Series and DataFrame, I'd add both here too. One of the links will be self-referencing, but the other will point to the equivalent of the other class, which is useful.

datapythonista · 2018-11-09T12:24:11Z

pandas/core/generic.py

-        to the on or level keyword.
+        series. Object must have a datetime-like index (``DatetimeIndex``,
+        ``PeriodIndex``, or ``TimedeltaIndex``), or pass datetime-like values
+        to the ``on`` or ``level`` keyword.


Single backticks.

datapythonista · 2018-11-09T12:25:25Z

pandas/core/generic.py

+        rule : str
+            The offset string or object representing target conversion.
+        how : str
+            Method for down-/re-sampling, default to ‘mean’ for downsampling.


What are the possible values? If they are a fixed set, can we have {'mean',...}? If it's a problem, leave it like it is, as this will go away soon.

Possible values are any valid string function that does some form of aggregation. Interestingly, this would also work with the example dataframe I shared above:

>>> df price volume time 0 10 50 2018-01-07 1 11 60 2018-01-14 2 9 40 2018-01-21 3 13 100 2018-01-28 4 14 50 2018-02-04 5 18 100 2018-02-11 6 17 40 2018-02-18 7 19 50 2018-02-25 >>> df.resample('M', on='time', how={'price': min, 'volume': sum}) price volume time 2018-01-31 9 250 2018-02-28 14 240 >>> df.resample('M', on='time', how=['min', 'sum']) price volume min sum min sum time 2018-01-31 9 43 40 250 2018-02-28 14 68 40 240

Happy to change the description of the parameter to something like:

how : str, dict, list Method for down-/re-sampling, default to `mean` for downsampling. Accepted combinations are: * string function name * list of string function names * dict of column names -> string function names (or list of string function names)

I got inspiration from pandas.DataFrame.aggregate.

f the name needs to be a string with the function name, I assume it can't be any arbitrary value. But as it's deprecated, let's not spend time on this.

jmrr · 2018-11-09T16:01:40Z

Thanks @datapythonista. I've addressed the changes but it's good you highlighted that as these docs are shared between Series and DataFrame some parameters might accept quite different values depending on the data structure.

Please see my comments and suggestions. Thanks!

datapythonista

lgtm, @jbrockmendel do you mind taking a look, and merge if you're happy?

datapythonista · 2018-11-09T16:55:00Z

@jmrr looks like the error in the CI is in this PR, a non-ascii character somewhere. Can you take a look and leave the CI green, so we can merge?

jmrr · 2018-11-09T16:57:45Z

Sure @datapythonista let me have a look. Thanks for the review!

pandas/core/generic.py

jmrr · 2018-11-09T17:51:39Z

Looks like it's still failing, but it's an issue with CI setup. The branch is encountering a pytest installation that is too new.

datapythonista · 2018-11-09T17:54:58Z

That's weird, I think that happened before and it was fixed. Can you merge master into your branch? May be it's based in the old failing version.

…ample

jbrockmendel · 2018-11-09T18:26:09Z

pandas/core/generic.py

+
+        >>> days = pd.date_range('1/1/2000', periods=4, freq='D')
+        >>> d2 = dict({'price': [10, 11, 9, 13, 14, 18, 17, 19],
+        ...           'volume': [50, 60, 40, 100, 50, 100, 40, 50]})


one more space?

jbrockmendel · 2018-11-09T18:26:36Z

Aside from one missing space, LGTM

datapythonista · 2018-11-09T18:29:07Z

pandas/core/generic.py

+
+        >>> days = pd.date_range('1/1/2000', periods=4, freq='D')
+        >>> d2 = dict({'price': [10, 11, 9, 13, 14, 18, 17, 19],
+        ...           'volume': [50, 60, 40, 100, 50, 100, 40, 50]})


Suggested change

... 'volume': [50, 60, 40, 100, 50, 100, 40, 50]})

... 'volume': [50, 60, 40, 100, 50, 100, 40, 50]})

datapythonista · 2018-11-09T18:32:04Z

@jmrr can you run ./scripts/validate_docstrings.py pandas.Series.resample I think it should capture the error in the indentation (and other formatting problems).

Also, can you remove the -resample in the doctests part of ci/code_checks.sh? doctests should pass for this now, and we don't need to skip it anymore.

jmrr · 2018-11-10T12:25:45Z

Thanks for the review @jbrockmendel and @datapythonista. Previous to the branch update with latest master, all tests passed when running ./scripts/validate_docstrings.py pandas.Series.resample.

Now after the update I encountered some errors, but they're flake8 ones. In particular:

2 Errors found:
        flake8 error: E302 expected 2 blank lines, found 0
        flake8 error: E305 expected 2 blank lines after class or function definition, found 0

I spent some time looking but I think this validation is trying to lint the example code as if this wasn't REPL code. For instance, the E302 disappears if I trick the linter with:

        >>>
        ...
        ... def custom_resampler(array_like):
        ...     return np.sum(array_like) + 5
        ...
        ...
        ...
        >>> series.resample('3T').apply(custom_resampler)

So there's two lines before a function.

Should I spend some time with this and commit the change or this is something that will get improved with time (e.g. by ignoring that error code).

datapythonista · 2018-11-10T21:46:46Z

Not sure what's the best solution here, but the problem is in how we validate flake8, we surely don't want to leave blank lines that way in here.

We'll address that in a separate PR in any case.

Thanks for the work on this @jmrr

CC: @alimcmaster1

…fixed * upstream/master: DOC: Fixes to docstring to add validation to CI (pandas-dev#23560) DOC: Remove incorrect periods at the end of parameter types (pandas-dev#23600) MAINT: tm.assert_raises_regex --> pytest.raises (pandas-dev#23592) DOC: Updating Series.resample and DataFrame.resample docstrings (pandas-dev#23197) ENH: Support for partition_cols in to_parquet (pandas-dev#23321) TST: Use intp as expected dtype in IntervalIndex indexing tests (pandas-dev#23609)

* upstream/master: BUG: Casting tz-aware DatetimeIndex to object-dtype ndarray/Index (pandas-dev#23524) BUG: Delegate more of Excel parsing to CSV (pandas-dev#23544) API: DataFrame.__getitem__ returns Series for sparse column (pandas-dev#23561) CLN: use float64_t consistently instead of double, double_t (pandas-dev#23583) DOC: Fix Order of parameters in docstrings (pandas-dev#23611) TST: Unskip some Categorical Tests (pandas-dev#23613) TST: Fix integer ops comparison test (pandas-dev#23619) DOC: Fixes to docstring to add validation to CI (pandas-dev#23560) DOC: Remove incorrect periods at the end of parameter types (pandas-dev#23600) MAINT: tm.assert_raises_regex --> pytest.raises (pandas-dev#23592) DOC: Updating Series.resample and DataFrame.resample docstrings (pandas-dev#23197)

…as-dev#23197)

jmrr added 5 commits October 17, 2018 11:22

DOC: Remove some validation errors in resample (pandas-dev#22894)

2c23296

* First iteration over some validation errors on pandas.Series.resample. * Fix multi-line examples issue.

DOC: Document deprecated parameters for resample (pandas-dev#22894)

7940cbe

Not too sure they were deprecated from v0.18.0. Need to point this out in the PR.

DOC: Validate PEP-8 of fixed resample docstrings (pandas-dev#22894)

ff8009e

DOC: Improve inline code reST display (pandas-dev#22894)

f71d48f

DOC: Simpler short summary (pandas-dev#22894)

49fbd6b

jmrr mentioned this pull request Oct 18, 2018

DOC: Fix the docstring of resample in pandas/core/generic.py #22894

Closed

jmrr changed the title ~~Fix docstring resample~~ DOC: Fix pandas.Series.resample docstring Oct 19, 2018

jschendel added the Docs label Oct 21, 2018

datapythonista requested changes Oct 27, 2018

View reviewed changes

DOC: Address PR changes request: string->str, missing defaults, pep8 …

b8f8b0e

…issues... (pandas-dev#22894)

datapythonista requested changes Nov 4, 2018

View reviewed changes

jmrr added 3 commits November 7, 2018 12:56

DOC: Address PR comments (I) axis type and defaults, improve resample…

ad1cada

… convention examples. (pandas-dev#22894)

DOC: Address PR comments (II) revamp example for the on parameter. (p…

ceff696

…andas-dev#22894)

DOC: Address PR comments (III) revamp example for the level paramet…

8cd9a89

…er and other cosmetical mods. (pandas-dev#22894)

Removing double space.

ce7886a

datapythonista reviewed Nov 9, 2018

View reviewed changes

DOC: Address latest PR comments (pandas-dev#22894)

abb2b58

datapythonista approved these changes Nov 9, 2018

View reviewed changes

DOC: Remove non-ASCII character.

bbddcd2

datapythonista reviewed Nov 9, 2018

View reviewed changes

pandas/core/generic.py Outdated Show resolved Hide resolved

DOC: Remove weird quotes in resample.

e0aef30

Merge remote-tracking branch 'upstream/master' into fix-docstring-res…

9b3c7d7

…ample

jbrockmendel reviewed Nov 9, 2018

View reviewed changes

datapythonista reviewed Nov 9, 2018

View reviewed changes

jmrr added 3 commits November 10, 2018 10:57

DOC: Add missing space.

fab0ad0

Enable CI check on resample docs.

7567e12

DOC: Remove some flake8 errors in resample docstring.

109e414

datapythonista merged commit b930303 into pandas-dev:master Nov 10, 2018

JustinZhengBC pushed a commit to JustinZhengBC/pandas that referenced this pull request Nov 14, 2018

DOC: Updating Series.resample and DataFrame.resample docstrings (pand…

af8ca26

…as-dev#23197)

tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018

DOC: Updating Series.resample and DataFrame.resample docstrings (pand…

8dd65cc

…as-dev#23197)

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

DOC: Updating Series.resample and DataFrame.resample docstrings (pand…

163796d

…as-dev#23197)

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

DOC: Updating Series.resample and DataFrame.resample docstrings (pand…

05f4441

…as-dev#23197)

		@@ -7577,9 +7598,9 @@ def resample(self, rule, how=None, axis=0, fill_method=None, closed=None,

		>>> time = pd.date_range('1/1/2000', periods=5, freq='T')
		>>> df2 = pd.DataFrame(data=10*[range(4)],

	... 'volume': [50, 60, 40, 100, 50, 100, 40, 50]})
	... 'volume': [50, 60, 40, 100, 50, 100, 40, 50]})

DOC: Fix pandas.Series.resample docstring #23197

DOC: Fix pandas.Series.resample docstring #23197

Conversation

jmrr commented Oct 17, 2018

pep8speaks commented Oct 17, 2018

datapythonista left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Oct 27, 2018 • edited Loading

Codecov Report

datapythonista left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmrr Nov 7, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmrr commented Nov 7, 2018

datapythonista left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmrr commented Nov 9, 2018

datapythonista left a comment

Choose a reason for hiding this comment

datapythonista commented Nov 9, 2018

jmrr commented Nov 9, 2018

jmrr commented Nov 9, 2018

datapythonista commented Nov 9, 2018

Choose a reason for hiding this comment

jbrockmendel commented Nov 9, 2018

Choose a reason for hiding this comment

datapythonista commented Nov 9, 2018

jmrr commented Nov 10, 2018

datapythonista commented Nov 10, 2018

codecov bot commented Oct 27, 2018 •

edited

Loading

jmrr Nov 7, 2018 •

edited

Loading