Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Remove incorrect periods at the end of parameter types (#23597) #23600

Merged
merged 1 commit into from
Nov 11, 2018
Merged

DOC: Remove incorrect periods at the end of parameter types (#23597) #23600

merged 1 commit into from
Nov 11, 2018

Conversation

meiermark
Copy link
Contributor

@pep8speaks
Copy link

Hello @meiermark! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Nov 9, 2018 •
edited
Loading

Codecov Report

Merging #23600 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23600   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files         161      161           
  Lines       51262    51262           
=======================================
  Hits        47292    47292           
  Misses       3970     3970
Flag Coverage Δ
#multiple 90.64% <ø> (ø) ⬆️
#single 42.33% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/indexes/multi.py 95.46% <ø> (ø) ⬆️
pandas/io/clipboards.py 100% <ø> (ø) ⬆️
pandas/core/series.py 93.7% <ø> (ø) ⬆️
pandas/core/dtypes/inference.py 98.38% <ø> (ø) ⬆️
pandas/core/indexes/datetimes.py 96.13% <ø> (ø) ⬆️
pandas/core/strings.py 98.58% <ø> (ø) ⬆️
pandas/core/generic.py 96.81% <ø> (ø) ⬆️
pandas/core/indexes/range.py 97.32% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f691711...3a68057. Read the comment docs.

gfyoung
gfyoung approved these changes Nov 11, 2018
View reviewed changes
Copy link
Member

@gfyoung gfyoung left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

cc @datapythonista : Anything needed to enforce the rule now that these violations have been fixed?

@datapythonista datapythonista merged commit 274ef6f into pandas-dev:master Nov 11, 2018
@gfyoung gfyoung added this to the 0.24.0 milestone Nov 11, 2018
@datapythonista
Copy link
Member

Thanks for taking care of those @meiermark

@gfyoung we don't have the validation of docstring in place yet, I'm adding it in #22854, I'll add this error there, so it starts to be checked when merged

@datapythonista datapythonista mentioned this pull request Nov 11, 2018
Merged
4 tasks
@meiermark meiermark deleted the docu_remove_wrong_dots branch November 11, 2018 02:20
thoo added a commit to thoo/pandas that referenced this pull request Nov 11, 2018
@thoo
Merge remote-tracking branch 'upstream/master' into io_csv_docstring_…
d0600f9 
…fixed

* upstream/master:
  DOC: Fixes to docstring to add validation to CI (pandas-dev#23560)
  DOC: Remove incorrect periods at the end of parameter types (pandas-dev#23600)
  MAINT: tm.assert_raises_regex --> pytest.raises (pandas-dev#23592)
  DOC: Updating Series.resample and DataFrame.resample docstrings (pandas-dev#23197)
  ENH: Support for partition_cols in to_parquet (pandas-dev#23321)
  TST: Use intp as expected dtype in IntervalIndex indexing tests (pandas-dev#23609)
thoo added a commit to thoo/pandas that referenced this pull request Nov 11, 2018
@thoo
Merge remote-tracking branch 'upstream/master' into to_html-to_string
e19bf6f 
* upstream/master:
  BUG: Casting tz-aware DatetimeIndex to object-dtype ndarray/Index (pandas-dev#23524)
  BUG: Delegate more of Excel parsing to CSV (pandas-dev#23544)
  API: DataFrame.__getitem__ returns Series for sparse column (pandas-dev#23561)
  CLN: use float64_t consistently instead of double, double_t (pandas-dev#23583)
  DOC: Fix Order of parameters in docstrings (pandas-dev#23611)
  TST: Unskip some Categorical Tests (pandas-dev#23613)
  TST: Fix integer ops comparison test (pandas-dev#23619)
  DOC: Fixes to docstring to add validation to CI (pandas-dev#23560)
  DOC: Remove incorrect periods at the end of parameter types (pandas-dev#23600)
  MAINT: tm.assert_raises_regex --> pytest.raises (pandas-dev#23592)
  DOC: Updating Series.resample and DataFrame.resample docstrings (pandas-dev#23197)
JustinZhengBC pushed a commit to JustinZhengBC/pandas that referenced this pull request Nov 14, 2018
@meiermark @JustinZhengBC
DOC: Remove incorrect periods at the end of parameter types (pandas-d…
cffdb0e 
…ev#23600)
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@meiermark @tm9k1
DOC: Remove incorrect periods at the end of parameter types (pandas-d…
e66dffb 
…ev#23600)
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@meiermark @Pingviinituutti
DOC: Remove incorrect periods at the end of parameter types (pandas-d…
8d93af8 
…ev#23600)
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@meiermark @Pingviinituutti
DOC: Remove incorrect periods at the end of parameter types (pandas-d…
3b60fdf 
…ev#23600)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfyoung gfyoung gfyoung approved these changes

Assignees
No one assigned
Labels
Clean Docs
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

DOC: Remove incorrect periods at the end of parameter types
4 participants
@meiermark @pep8speaks @datapythonista @gfyoung