Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Auto-cancel redundant builds #23523

Merged
merged 7 commits into from
Nov 8, 2018
Merged

CI: Auto-cancel redundant builds #23523

merged 7 commits into from
Nov 8, 2018

Conversation

TomAugspurger
Copy link
Contributor

@TomAugspurger TomAugspurger commented Nov 5, 2018 •
edited
Loading

This removes the workflows section from the cirleci config, which broke auto-cancellation.

Also testing whether azure auto-cancels builds.

cc @gfyoung

@TomAugspurger
Copy link
Contributor Author

I've had 3 commits

  1. the initial commit when opening the PR
  2. a second commit cancel? after the CIs received their web hook notification
  3. a third commit cancel 2? after the Cis received their second web hook notification

@TomAugspurger
Copy link
Contributor Author

In theory, https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=2495&view=logs should not be built, since there are later commits on the same branch.

@TomAugspurger
Copy link
Contributor Author

TomAugspurger commented Nov 5, 2018 •
edited
Loading

Heh, this was testing azure, but I notice circleci isn't cancelling either.

https://discuss.circleci.com/t/auto-cancel-redundant-builds-not-working-for-workflow/13852/33 says that workflows don't support it yet, but we don't need workflows anymore, since we only have a single build. Will make this into a real PR now :)

@TomAugspurger
Copy link
Contributor Author

OK, all of these should be auto-canceled

If iI notice https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=2495&view=logs starting though, I'll cancel then all.

@gfyoung
Copy link
Member

gfyoung commented Nov 5, 2018

screen shot 2018-11-05 at 2 23 11 pm

I see five (not cancelled) builds...

@TomAugspurger
Copy link
Contributor Author

I'm hoping they're canceled when the build (attempts to) start?

@gfyoung
Copy link
Member

gfyoung commented Nov 5, 2018

I'm hoping they're canceled when the build (attempts to) start?

Maybe? Even so, I prefer Travis' behavior of auto-detecting and cancelling before they even get a chance to start, but perhaps I'm a bit spoiled by Travis :)

@TomAugspurger TomAugspurger changed the title [ignore, testing azure auto cancellation] CI: Auto-cancel redundant builds Nov 5, 2018
@gfyoung gfyoung added CI Continuous Integration Clean labels Nov 6, 2018
@TomAugspurger
Copy link
Contributor Author

https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=2495&view=logs ran, even though we'd like it to have been auto-canceled (I manually canceled the last two).

@chrispatterson do you know if azure pipelines supports auto-cancelling builds when a branch has new commits? Something similar to what's described in https://blog.travis-ci.com/2017-03-22-introducing-auto-cancellation. If not, is there a place I should go to voice support for that feature?

@TomAugspurger
Copy link
Contributor Author

@vtbassmatt do you know if there's a way to auto-cancel queued (or maybe running) builds when new commits are pushed to a PR branch?

@vtbassmatt
Copy link
Contributor

That should be the current behavior. (In fact, we've been asked for an explicit flag to override that behavior, which we're in the process of building.) @davidstaheli any thoughts on why Pandas PR pipelines aren't auto-canceling?

@codecov
Copy link

codecov bot commented Nov 7, 2018 •
edited
Loading

Codecov Report

Merging #23523 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23523   +/-   ##
=======================================
  Coverage   92.26%   92.26%           
=======================================
  Files         161      161           
  Lines       51212    51212           
=======================================
  Hits        47252    47252           
  Misses       3960     3960
Flag Coverage Δ
#multiple 90.65% <ø> (ø) ⬆️
#single 42.28% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6820ac...870de2b. Read the comment docs.

@davidstaheli
Copy link

@TomAugspurger, this is a bug specific to using the Azure Pipelines GitHub App. I'm so sorry for the time it cost you! We should have a fix deployed to production tomorrow (Thursday) or Friday.

@jreback jreback added this to the 0.24.0 milestone Nov 8, 2018
@jreback
Copy link
Contributor

jreback commented Nov 8, 2018

@TomAugspurger lgtm. Pls merge if this will fix the issue.

@TomAugspurger
Copy link
Contributor Author

This will hopefully fix circle. Azure should be fixed with no config changeable.

@TomAugspurger TomAugspurger merged commit af602c5 into pandas-dev:master Nov 8, 2018
@datapythonista datapythonista mentioned this pull request Nov 8, 2018
Merged
4 tasks
@TomAugspurger TomAugspurger deleted the test-azure-auto-cancel branch November 9, 2018 12:40
thoo added a commit to thoo/pandas that referenced this pull request Nov 10, 2018
@thoo
Merge remote-tracking branch 'upstream/master' into io_csv_docstring_…
d84ffb2 
…fixed

* upstream/master: (47 commits)
  CLN: remove values attribute from datetimelike EAs (pandas-dev#23603)
  DOC/CI: Add linting to rst files, and fix issues (pandas-dev#23381)
  PERF: Speeds up creation of Period, PeriodArray, with Offset freq (pandas-dev#23589)
  PERF: define is_all_dates to shortcut inadvertent copy when slicing an IntervalIndex (pandas-dev#23591)
  TST: Tests and Helpers for Datetime/Period Arrays (pandas-dev#23502)
  Update description of Index._values/values/ndarray_values (pandas-dev#23507)
  Fixes to make validate_docstrings.py not generate warnings or unwanted output (pandas-dev#23552)
  DOC: Added note about groupby excluding Decimal columns by default (pandas-dev#18953)
  ENH: Support writing timestamps with timezones with to_sql (pandas-dev#22654)
  CI: Auto-cancel redundant builds (pandas-dev#23523)
  Preserve EA dtype in DataFrame.stack (pandas-dev#23285)
  TST: Fix dtype mismatch on 32bit in IntervalTree get_indexer test (pandas-dev#23468)
  BUG: raise if invalid freq is passed (pandas-dev#23546)
  remove uses of (ts)?lib.(NaT|iNaT|Timestamp) (pandas-dev#23562)
  BUG: Fix error message for invalid HTML flavor (pandas-dev#23550)
  ENH: Support EAs in Series.unstack (pandas-dev#23284)
  DOC: Updating DataFrame.join docstring (pandas-dev#23471)
  TST: coverage for skipped tests in io/formats/test_to_html.py (pandas-dev#22888)
  BUG: Return KeyError for invalid string key (pandas-dev#23540)
  BUG: DatetimeIndex slicing with boolean Index raises TypeError (pandas-dev#22852)
  ...
@datapythonista
Copy link
Member

@davidstaheli just in case you're not aware, auto-cancel is still not working

@davidstaheli
Copy link

Thanks @datapythonista. It looks like deployment was delayed at the end of last week and is proceeding again. Fingers crossed, the fix will be in production by Tuesday afternoon (eastern time) at the latest.

@datapythonista
Copy link
Member

I guessed it was just delayed, but wanted to let you know just in case you thought it was fix. Thanks for the update @davidstaheli

JustinZhengBC pushed a commit to JustinZhengBC/pandas that referenced this pull request Nov 14, 2018
@TomAugspurger @JustinZhengBC
CI: Auto-cancel redundant builds (pandas-dev#23523)
cf5e385
@datapythonista
Copy link
Member

@davidstaheli I'd say that auto-cancel is still not working, is that expected?

tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@TomAugspurger @tm9k1
CI: Auto-cancel redundant builds (pandas-dev#23523)
014197a
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@TomAugspurger @Pingviinituutti
CI: Auto-cancel redundant builds (pandas-dev#23523)
b26d165
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@TomAugspurger @Pingviinituutti
CI: Auto-cancel redundant builds (pandas-dev#23523)
6550ae7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI Continuous Integration Clean
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@TomAugspurger @gfyoung @vtbassmatt @davidstaheli @jreback @datapythonista