Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove uses of (ts)?lib.(NaT|iNaT|Timestamp) #23562

Merged
merged 2 commits into from Nov 8, 2018
Merged

remove uses of (ts)?lib.(NaT|iNaT|Timestamp) #23562

merged 2 commits into from Nov 8, 2018

Conversation

jbrockmendel
Copy link
Member

Since they are no longer defined there; instead import then from more appropriate places.

@pep8speaks
Copy link

Hello @jbrockmendel! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Nov 8, 2018 •
edited

Codecov Report

Merging #23562 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23562   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files         161      161           
  Lines       51224    51224           
=======================================
  Hits        47254    47254           
  Misses       3970     3970
Flag Coverage Δ
#multiple 90.63% <100%> (ø) ⬆️
#single 42.28% <57.14%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/generic.py 96.81% <100%> (ø) ⬆️
pandas/core/indexes/period.py 92.25% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8212001...bf7249d. Read the comment docs.

@jbrockmendel jbrockmendel changed the title remove uses of (ts?)lib.(NaT|iNaT|Timestamp) remove uses of (ts)?lib.(NaT|iNaT|Timestamp) Nov 8, 2018
@gfyoung gfyoung added Refactor Internal refactoring of code Internals Related to non-user accessible pandas implementation labels Nov 8, 2018
gfyoung
gfyoung approved these changes Nov 8, 2018
View reviewed changes
Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice regex-ish title as well. 🙂

cc @jreback

@jreback jreback added this to the 0.24.0 milestone Nov 8, 2018
@jreback jreback merged commit 712fa94 into pandas-dev:master Nov 8, 2018
@jreback
Copy link
Contributor

jreback commented Nov 8, 2018

thanks!

@jbrockmendel jbrockmendel deleted the cln2 branch November 8, 2018 14:48
thoo added a commit to thoo/pandas that referenced this pull request Nov 10, 2018
@thoo
Merge remote-tracking branch 'upstream/master' into io_csv_docstring_…
d84ffb2 
…fixed

* upstream/master: (47 commits)
  CLN: remove values attribute from datetimelike EAs (pandas-dev#23603)
  DOC/CI: Add linting to rst files, and fix issues (pandas-dev#23381)
  PERF: Speeds up creation of Period, PeriodArray, with Offset freq (pandas-dev#23589)
  PERF: define is_all_dates to shortcut inadvertent copy when slicing an IntervalIndex (pandas-dev#23591)
  TST: Tests and Helpers for Datetime/Period Arrays (pandas-dev#23502)
  Update description of Index._values/values/ndarray_values (pandas-dev#23507)
  Fixes to make validate_docstrings.py not generate warnings or unwanted output (pandas-dev#23552)
  DOC: Added note about groupby excluding Decimal columns by default (pandas-dev#18953)
  ENH: Support writing timestamps with timezones with to_sql (pandas-dev#22654)
  CI: Auto-cancel redundant builds (pandas-dev#23523)
  Preserve EA dtype in DataFrame.stack (pandas-dev#23285)
  TST: Fix dtype mismatch on 32bit in IntervalTree get_indexer test (pandas-dev#23468)
  BUG: raise if invalid freq is passed (pandas-dev#23546)
  remove uses of (ts)?lib.(NaT|iNaT|Timestamp) (pandas-dev#23562)
  BUG: Fix error message for invalid HTML flavor (pandas-dev#23550)
  ENH: Support EAs in Series.unstack (pandas-dev#23284)
  DOC: Updating DataFrame.join docstring (pandas-dev#23471)
  TST: coverage for skipped tests in io/formats/test_to_html.py (pandas-dev#22888)
  BUG: Return KeyError for invalid string key (pandas-dev#23540)
  BUG: DatetimeIndex slicing with boolean Index raises TypeError (pandas-dev#22852)
  ...
JustinZhengBC pushed a commit to JustinZhengBC/pandas that referenced this pull request Nov 14, 2018
@jbrockmendel @JustinZhengBC
remove uses of (ts)?lib.(NaT|iNaT|Timestamp) (pandas-dev#23562)
6d4178a
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@jbrockmendel @tm9k1
remove uses of (ts)?lib.(NaT|iNaT|Timestamp) (pandas-dev#23562)
23854f9
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jbrockmendel @Pingviinituutti
remove uses of (ts)?lib.(NaT|iNaT|Timestamp) (pandas-dev#23562)
824ded7
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jbrockmendel @Pingviinituutti
remove uses of (ts)?lib.(NaT|iNaT|Timestamp) (pandas-dev#23562)
d35b890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfyoung gfyoung gfyoung approved these changes

Assignees
No one assigned
Labels
Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jbrockmendel @pep8speaks @jreback @gfyoung