CLN: Finish isort core #23765
CLN: Finish isort core #23765
Conversation
|
Hello @alimcmaster1! Thanks for submitting the PR.
|
pandas/core/indexes/frozen.py
Outdated
| from pandas.util._decorators import deprecate_kwarg | ||
|
|
There was a problem hiding this comment.
Hmm what's with the empty lines between from statements here? Not seeing that anywhere else?
There was a problem hiding this comment.
These are separate sections see the isort section in the setup.cfg for latest spec.
pandas/core/indexes/numeric.py
Outdated
| from pandas._libs import index as libindex | ||
| from pandas.util._decorators import Appender, cache_readonly |
There was a problem hiding this comment.
Isn't this supposed to be alphabetical? Should come after the following import, no?
There was a problem hiding this comment.
Within pandas imports are by dependency structure opposed to alphabetically - see this change #23366
|
Thanks for taking a look @WillAyd just actually removed a bunch of files to aid reviewing this |
|
thanks @alimcmaster1 btw these are going really well, don't mind having more files in each PR. |
|
ping on green. |
|
small linting issue in the 3.6 build run
|
Codecov Report
@@ Coverage Diff @@
## master #23765 +/- ##
==========================================
+ Coverage 92.27% 92.28% +0.01%
==========================================
Files 161 161
Lines 51411 51449 +38
==========================================
+ Hits 47439 47481 +42
+ Misses 3972 3968 -4
Continue to review full report at Codecov.
|
|
thanks @alimcmaster1 |
…fixed * upstream/master: DOC: more consistent flake8-commands in contributing.rst (pandas-dev#23724) DOC: Fixed the doctsring for _set_axis_name (GH 22895) (pandas-dev#22969) DOC: Improve GL03 message re: blank lines at end of docstrings. (pandas-dev#23649) TST: add tests for keeping dtype in Series.update (pandas-dev#23604) TST: For GH4861, Period and datetime in multiindex (pandas-dev#23776) TST: move .str-test to strings.py & parametrize it; precursor to pandas-dev#23582 (pandas-dev#23777) STY: isort tests/scalar, tests/tslibs, import libwindow instead of _window (pandas-dev#23787) BUG: fixed .str.contains(..., na=False) for categorical series (pandas-dev#22170) BUG: Maintain column order with groupby.nth (pandas-dev#22811) API/DEPR: replace kwarg "pat" with "sep" in str.[r]partition (pandas-dev#23767) CLN: Finish isort core (pandas-dev#23765) TST: Mark test_pct_max_many_rows with pytest.mark.single (pandas-dev#23799)
git diff upstream/master -u -- "*.py" | flake8 --diff