BUG: GH24011 - Rich comparisons of Timestamps now return NotImplemented #24021

AlexandreDecan · 2018-11-30T17:49:28Z

closes Rich comparisons of Timestamps raise TypeError instead of returning NotImplemented #24011
tests added / passed (see https://github.com/AlexandreDecan/pandas/blob/fix-24011/pandas/tests/tslibs/test_tslib.py#L26)
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

pep8speaks · 2018-11-30T17:49:30Z

Hello @AlexandreDecan! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-04-01 12:13:42 UTC

AlexandreDecan · 2018-11-30T20:01:38Z

Tests did not fail locally. I will have a closer look to see why.

jbrockmendel · 2018-12-02T17:15:15Z

@AlexandreDecan did this become more time-sensitive, or can it still wait until January?

pandas/_libs/tslibs/timestamps.pyx

pandas/tests/tslibs/test_tslib.py

AlexandreDecan · 2018-12-02T18:37:43Z

@AlexandreDecan did this become more time-sensitive, or can it still wait until January?

It can wait until January, I have temporary workarounds. For simplicity, should I close this PR until January?

jbrockmendel · 2018-12-02T19:38:16Z

For simplicity, should I close this PR until January?

No, it just means I won't feel bad about taking my time to form an opinion.

AlexandreDecan · 2018-12-02T19:48:51Z

You should never feel bad about taking time to form an opinion 😉

codecov · 2018-12-02T21:28:31Z

Codecov Report

Merging #24021 into master will decrease coverage by 49.86%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #24021       +/-   ##
===========================================
- Coverage   92.31%   42.45%   -49.87%     
===========================================
  Files         161      161               
  Lines       51549    51561       +12     
===========================================
- Hits        47586    21888    -25698     
- Misses       3963    29673    +25710

Flag	Coverage Δ
#multiple	`?`
#single	`42.45% <ø> (ø)`	⬆️

Impacted Files	Coverage Δ
pandas/io/formats/latex.py	`0% <0%> (-100%)`	⬇️
pandas/core/categorical.py	`0% <0%> (-100%)`	⬇️
pandas/io/sas/sas_constants.py	`0% <0%> (-100%)`	⬇️
pandas/tseries/plotting.py	`0% <0%> (-100%)`	⬇️
pandas/tseries/converter.py	`0% <0%> (-100%)`	⬇️
pandas/io/formats/html.py	`0% <0%> (-97.64%)`	⬇️
pandas/core/groupby/categorical.py	`0% <0%> (-95.46%)`	⬇️
pandas/io/sas/sas7bdat.py	`0% <0%> (-91.17%)`	⬇️
pandas/io/sas/sas_xport.py	`0% <0%> (-90.15%)`	⬇️
pandas/core/tools/numeric.py	`10.44% <0%> (-89.56%)`	⬇️
... and 119 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc8d35a...1be836d. Read the comment docs.

codecov · 2018-12-02T21:28:31Z

Codecov Report

Merging #24021 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #24021      +/-   ##
==========================================
- Coverage   91.82%   91.81%   -0.01%     
==========================================
  Files         175      175              
  Lines       52580    52581       +1     
==========================================
- Hits        48279    48276       -3     
- Misses       4301     4305       +4

Flag	Coverage Δ
#multiple	`90.36% <ø> (ø)`	⬆️
#single	`41.89% <ø> (-0.08%)`	⬇️

Impacted Files	Coverage Δ
pandas/io/gbq.py	`75% <0%> (-12.5%)`	⬇️
pandas/core/frame.py	`96.79% <0%> (-0.12%)`	⬇️
pandas/_config/config.py	`86.86% <0%> (+0.04%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3989e47...bfda6c3. Read the comment docs.

jreback · 2018-12-14T15:57:59Z

@jbrockmendel so deferring this to 0.25, can you PR for reverting the Timedelta change.

WillAyd · 2019-02-27T23:53:06Z

Closing as stale. Ping if you'd like to continue

AlexandreDecan · 2019-02-28T06:28:00Z

Ping!? Waiting for info in #24011

WillAyd · 2019-02-28T07:04:24Z

@AlexandreDecan sounds good I've reopened. FWIW this would go in on 0.25 at the earliest at which point we drop Python2 support, so any compat issues there are not really a concern. Briefly read through the rest of the issue and wasn't clear what info you might be waiting for so let me know if I overlooked.

Otherwise feel free to merge master

AlexandreDecan · 2019-02-28T08:00:40Z

It wasn't clear to me what is the plan for this issue/PR. I'll add some tests to this PR asap (probably not before tomorrow).

AlexandreDecan · 2019-02-28T08:10:11Z

I forgot that there are already some tests. I'll merge master, and update the what's new entry according to the guidelines (need to find them first ;-)

AlexandreDecan · 2019-03-02T11:32:12Z

What about the existing tests that are explicitly failing because of this change? Could I remove/adapt them, or should this be part of another PR?

doc/source/whatsnew/v0.25.0.rst

pandas/tests/scalar/timestamp/test_comparisons.py

TomAugspurger

Looks like your test is failing on CI.

doc/source/whatsnew/v0.25.0.rst

AlexandreDecan · 2019-03-05T09:29:14Z

I've just fixed the test. Sorry for that, I should have checked before pushing the commits ;-)

TomAugspurger · 2019-03-05T12:01:55Z

Try it out. It may work.

…

On Tue, Mar 5, 2019 at 5:57 AM Alexandre Decan ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In doc/source/whatsnew/v0.25.0.rst <#24021 (comment)>: > @@ -33,6 +33,9 @@ Backwards incompatible API changes .. _whatsnew_0250.api_breaking.utc_offset_indexing: +- Comparing :class:`~Timestamp.Timestamp` with unsupported objects now returns ``NotImplemented`` instead of raising ``TypeError``. This implies that unsupported rich comparisons are delegated to the other object, and is now consistent with Python 3 behavior for ``datetime`` objects (:issue:`24011`) I think NotImplemented is an object, not a class (see https://github.com/python/cpython/blob/4d61e6e3b802399be62a521d6fa785698cb670b5/Objects/object.c#L1730). Am I wrong? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#24021 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQHIksDQENa8fhBKNWCg9MeqGGdGuPLks5vTluxgaJpZM4Y8HOu> .

TomAugspurger · 2019-03-05T12:03:27Z

If not, you can include a ref to https://docs.python.org/3/library/constants.html#NotImplemented On Tue, Mar 5, 2019 at 6:01 AM Tom Augspurger <tom.augspurger88@gmail.com> wrote:

…

Try it out. It may work. On Tue, Mar 5, 2019 at 5:57 AM Alexandre Decan ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In doc/source/whatsnew/v0.25.0.rst > <#24021 (comment)>: > > > @@ -33,6 +33,9 @@ Backwards incompatible API changes > > .. _whatsnew_0250.api_breaking.utc_offset_indexing: > > +- Comparing :class:`~Timestamp.Timestamp` with unsupported objects now returns ``NotImplemented`` instead of raising ``TypeError``. This implies that unsupported rich comparisons are delegated to the other object, and is now consistent with Python 3 behavior for ``datetime`` objects (:issue:`24011`) > > I think NotImplemented is an object, not a class (see > https://github.com/python/cpython/blob/4d61e6e3b802399be62a521d6fa785698cb670b5/Objects/object.c#L1730). > Am I wrong? > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#24021 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ABQHIksDQENa8fhBKNWCg9MeqGGdGuPLks5vTluxgaJpZM4Y8HOu> > . >

AlexandreDecan · 2019-03-05T12:33:50Z

I tested and it works. Thanks!

jreback

small change. I think we can merge this as soon a PY2 ci (#24942) & numpy 1.13 bump (#25554) happens, soon.

doc/source/whatsnew/v0.25.0.rst

jreback · 2019-03-20T01:54:21Z

can you merge master

AlexandreDecan · 2019-04-01T11:15:54Z

Both PY2 ci (#24942) & numpy 1.13 bump (#25554) have been merged.
Any update for this PR?

jreback · 2019-04-01T11:39:56Z

pls merge master

AlexandreDecan · 2019-04-01T11:48:43Z

Done.

How many times will I have to merge master? I already did it 12 days ago, when you asked... :)

jreback · 2019-04-01T12:10:11Z

pr was failing the CI

How many times will I have to merge master? I already did it 12 days ago, when you asked... :)

we have quite a number of PRs and they are need updating especially when thing change. 12 days is a long time.

doc/source/whatsnew/v0.25.0.rst

pandas/tests/scalar/timestamp/test_comparisons.py

jreback · 2019-04-01T12:11:30Z

@jbrockmendel if you have comments

jreback · 2019-04-05T00:40:52Z

thanks @AlexandreDecan

AlexandreDecan added 3 commits November 30, 2018 18:35

BUG: GH24011

e3ac3c9

TST: GH24011

f5eee0a

CLN: Remove trailing spaces & compound operations

3ab8be2

gfyoung added Datetime Datetime data dtype API Design labels Dec 2, 2018

gfyoung requested a review from jbrockmendel December 2, 2018 10:07

jbrockmendel reviewed Dec 2, 2018

View reviewed changes

pandas/_libs/tslibs/timestamps.pyx Show resolved Hide resolved

jbrockmendel reviewed Dec 2, 2018

View reviewed changes

pandas/tests/tslibs/test_tslib.py Outdated Show resolved Hide resolved

jbrockmendel reviewed Dec 2, 2018

View reviewed changes

pandas/tests/tslibs/test_tslib.py Outdated Show resolved Hide resolved

jbrockmendel reviewed Dec 2, 2018

View reviewed changes

pandas/tests/tslibs/test_tslib.py Outdated Show resolved Hide resolved

AlexandreDecan added 2 commits December 2, 2018 20:01

Changes following code review 1 (#24021)

490b97f

Fix pep8

1be836d

jbrockmendel mentioned this pull request Dec 4, 2018

RLS: 0.24.0 #24060

Closed

jreback added this to the 0.25.0 milestone Dec 14, 2018

WillAyd closed this Feb 27, 2019

WillAyd reopened this Feb 28, 2019

AlexandreDecan added 2 commits February 28, 2019 09:14

Merge remote-tracking branch 'upstream/master' into fix-24011

5863e5b

what's new entry

1882a09

jreback requested changes Mar 3, 2019

View reviewed changes

doc/source/whatsnew/v0.25.0.rst Outdated Show resolved Hide resolved

pandas/tests/scalar/timestamp/test_comparisons.py Outdated Show resolved Hide resolved

pandas/tests/scalar/timestamp/test_comparisons.py Outdated Show resolved Hide resolved

CLN: Doc & test for GH24011

117da8d

TomAugspurger reviewed Mar 5, 2019

View reviewed changes

doc/source/whatsnew/v0.25.0.rst Outdated Show resolved Hide resolved

AlexandreDecan added 2 commits March 5, 2019 10:13

CLN: Link to NotImplemented & Typo

a6c9144

TST: Fix test for GH24011

f332f56

CLN: Typo

f9cbefe

CLN: Flake8

314aedd

jreback requested changes Mar 10, 2019

View reviewed changes

doc/source/whatsnew/v0.25.0.rst Outdated Show resolved Hide resolved

CLN: Move entry

8e57a75

Merge master

70c3f06

Merge remote-tracking branch 'upstream/master' into fix-24011

85b64ea

jreback requested changes Apr 1, 2019

View reviewed changes

doc/source/whatsnew/v0.25.0.rst Show resolved Hide resolved

pandas/tests/scalar/timestamp/test_comparisons.py Outdated Show resolved Hide resolved

CLN: White lines & issue ref

bfda6c3

jreback approved these changes Apr 5, 2019

View reviewed changes

jreback merged commit a193df1 into pandas-dev:master Apr 5, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BUG: GH24011 - Rich comparisons of Timestamps now return NotImplemented #24021

BUG: GH24011 - Rich comparisons of Timestamps now return NotImplemented #24021

AlexandreDecan commented Nov 30, 2018 •

edited

Loading

pep8speaks commented Nov 30, 2018 •

edited

Loading

AlexandreDecan commented Nov 30, 2018

jbrockmendel commented Dec 2, 2018

AlexandreDecan commented Dec 2, 2018

jbrockmendel commented Dec 2, 2018

AlexandreDecan commented Dec 2, 2018

codecov bot commented Dec 2, 2018

codecov bot commented Dec 2, 2018 •

edited

Loading

jreback commented Dec 14, 2018

WillAyd commented Feb 27, 2019

AlexandreDecan commented Feb 28, 2019

WillAyd commented Feb 28, 2019

AlexandreDecan commented Feb 28, 2019

AlexandreDecan commented Feb 28, 2019

AlexandreDecan commented Mar 2, 2019

TomAugspurger left a comment

AlexandreDecan commented Mar 5, 2019

TomAugspurger commented Mar 5, 2019 via email

TomAugspurger commented Mar 5, 2019 via email

AlexandreDecan commented Mar 5, 2019

jreback left a comment

jreback commented Mar 20, 2019

AlexandreDecan commented Apr 1, 2019

jreback commented Apr 1, 2019

AlexandreDecan commented Apr 1, 2019 •

edited

Loading

jreback commented Apr 1, 2019

jreback commented Apr 1, 2019

jreback commented Apr 5, 2019

BUG: GH24011 - Rich comparisons of Timestamps now return NotImplemented #24021

BUG: GH24011 - Rich comparisons of Timestamps now return NotImplemented #24021

Conversation

AlexandreDecan commented Nov 30, 2018 • edited Loading

pep8speaks commented Nov 30, 2018 • edited Loading

Comment last updated at 2019-04-01 12:13:42 UTC

AlexandreDecan commented Nov 30, 2018

jbrockmendel commented Dec 2, 2018

AlexandreDecan commented Dec 2, 2018

jbrockmendel commented Dec 2, 2018

AlexandreDecan commented Dec 2, 2018

codecov bot commented Dec 2, 2018

Codecov Report

codecov bot commented Dec 2, 2018 • edited Loading

Codecov Report

jreback commented Dec 14, 2018

WillAyd commented Feb 27, 2019

AlexandreDecan commented Feb 28, 2019

WillAyd commented Feb 28, 2019

AlexandreDecan commented Feb 28, 2019

AlexandreDecan commented Feb 28, 2019

AlexandreDecan commented Mar 2, 2019

TomAugspurger left a comment

Choose a reason for hiding this comment

AlexandreDecan commented Mar 5, 2019

TomAugspurger commented Mar 5, 2019 via email

TomAugspurger commented Mar 5, 2019 via email

AlexandreDecan commented Mar 5, 2019

jreback left a comment

Choose a reason for hiding this comment

jreback commented Mar 20, 2019

AlexandreDecan commented Apr 1, 2019

jreback commented Apr 1, 2019

AlexandreDecan commented Apr 1, 2019 • edited Loading

jreback commented Apr 1, 2019

jreback commented Apr 1, 2019

jreback commented Apr 5, 2019

AlexandreDecan commented Nov 30, 2018 •

edited

Loading

pep8speaks commented Nov 30, 2018 •

edited

Loading

codecov bot commented Dec 2, 2018 •

edited

Loading

AlexandreDecan commented Apr 1, 2019 •

edited

Loading