Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Pinning flake8-rst, last version raises incorrect errors #24756

Merged
merged 3 commits into from
Jan 13, 2019
Merged

CI: Pinning flake8-rst, last version raises incorrect errors #24756

merged 3 commits into from
Jan 13, 2019

Conversation

datapythonista
Copy link
Member

  • closes CI: azure failing #24755
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

CC: @jreback @FHaase

@datapythonista datapythonista added Docs CI Continuous Integration labels Jan 13, 2019
@jreback jreback added this to the 0.24.0 milestone Jan 13, 2019
@@ -14,7 +14,7 @@ dependencies:
- cython>=0.28.2
- flake8
- flake8-comprehensions
- flake8-rst>=0.6.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just make >=0.6.0<=0.7.0 for now

@datapythonista
Copy link
Member Author

done

@jreback
Copy link
Contributor

jreback commented Jan 13, 2019

cool. merge on pass.

@codecov
Copy link

codecov bot commented Jan 13, 2019

Codecov Report

Merging #24756 into master will decrease coverage by 49.46%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #24756       +/-   ##
===========================================
- Coverage   92.38%   42.91%   -49.47%     
===========================================
  Files         166      166               
  Lines       52363    52363               
===========================================
- Hits        48376    22473    -25903     
- Misses       3987    29890    +25903
Flag Coverage Δ
#multiple ?
#single 42.91% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/core/categorical.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/tseries/converter.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-99.35%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-95.46%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.17%) ⬇️
pandas/io/sas/sas_xport.py 0% <0%> (-90.15%) ⬇️
pandas/core/tools/numeric.py 10.44% <0%> (-89.56%) ⬇️
... and 123 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f160c7d...6443eff. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 13, 2019

Codecov Report

Merging #24756 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24756   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files         166      166           
  Lines       52363    52363           
=======================================
  Hits        48376    48376           
  Misses       3987     3987
Flag Coverage Δ
#multiple 90.81% <ø> (ø) ⬆️
#single 42.91% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f160c7d...3664cbf. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Jan 13, 2019

requirements-dev.txt(,): error : `requirements-dev.txt` has to be generated with `ci/../scripts/generate_pip_deps_from_conda.py` after `environment.yml` is modified.
Bash exited with code '1'.

@datapythonista
Copy link
Member Author

Just saw it, luckily the syntax for >= and <= seems to be the same in pip as in conda, will push in a second, after I finish testing.

@datapythonista datapythonista merged commit 10a353b into pandas-dev:master Jan 13, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@WillAyd WillAyd mentioned this pull request Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: azure failing
2 participants