BUG: Raise KeyError when indexing a Series with MultiIndex #26155

ryanreh99 · 2019-04-20T01:20:03Z

closes Wrong "Too many indexers" error message when indexing a Series with MultiIndex #14885
tests added / passed
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

pep8speaks · 2019-04-20T01:20:07Z

Hello @ryanreh99! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-04-24 14:32:03 UTC

codecov · 2019-04-20T01:54:51Z

Codecov Report

Merging #26155 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #26155      +/-   ##
==========================================
- Coverage      92%   91.98%   -0.02%     
==========================================
  Files         175      175              
  Lines       52371    52378       +7     
==========================================
- Hits        48184    48182       -2     
- Misses       4187     4196       +9

Flag	Coverage Δ
#multiple	`90.54% <100%> (-0.01%)`	⬇️
#single	`40.74% <0%> (-0.15%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/indexing.py	`90.56% <100%> (-0.32%)`	⬇️
pandas/io/gbq.py	`75% <0%> (-12.5%)`	⬇️
pandas/core/frame.py	`96.9% <0%> (-0.12%)`	⬇️
pandas/core/indexes/base.py	`96.94% <0%> (-0.06%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c79b7bb...31df19b. Read the comment docs.

codecov · 2019-04-20T01:54:51Z

Codecov Report

Merging #26155 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #26155      +/-   ##
==========================================
- Coverage   91.98%   91.97%   -0.02%     
==========================================
  Files         175      175              
  Lines       52371    52375       +4     
==========================================
- Hits        48175    48171       -4     
- Misses       4196     4204       +8

Flag	Coverage Δ
#multiple	`90.52% <100%> (-0.01%)`	⬇️
#single	`40.7% <0%> (-0.16%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/indexing.py	`90.53% <100%> (-0.35%)`	⬇️
pandas/io/gbq.py	`78.94% <0%> (-10.53%)`	⬇️
pandas/core/computation/engines.py	`88.33% <0%> (-0.2%)`	⬇️
pandas/core/frame.py	`96.9% <0%> (-0.12%)`	⬇️
pandas/core/indexes/base.py	`96.94% <0%> (-0.06%)`	⬇️
pandas/core/algorithms.py	`94.8% <0%> (+0.01%)`	⬆️
pandas/util/testing.py	`90.71% <0%> (+0.1%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 947bd76...2309e14. Read the comment docs.

jreback

you additions make this way more complicated, see if you can simplify

pandas/core/indexing.py

pandas/core/indexes/base.py

jreback

pls add a whatsnew note in bug fixes; indexing section. the code change looks good.

pandas/tests/indexing/multiindex/test_loc.py

pandas/core/indexing.py

jreback

small comments, ping on green.

pandas/core/indexing.py

pandas/tests/indexing/multiindex/test_loc.py

ryanreh99 · 2019-04-23T16:22:39Z

hello @jreback ping

jreback · 2019-04-24T12:31:16Z

doc/source/whatsnew/v0.25.0.rst

@@ -327,6 +327,7 @@ Indexing
 ^^^^^^^^

 - Improved exception message when calling :meth:`DataFrame.iloc` with a list of non-numeric objects (:issue:`25753`).
+- Bug in :meth:`DataFrame.loc` and :meth:`Series.loc` where KeyError was not raised for a ``MultiIndex``. Now, IndexingError takes precedence over KeyError (:issue:`14885`).


use double backticks on KeyError; use :class:`MultiIndex` ; maybe something more like

Bug in :meth:DataFrame.loc and :meth:Series.loc where KeyError was not raised for a MultiIndex when the key was longer that the number of levels in the :class:MUutiIndex. (:issue:14885).

@jreback actually when key is longer than the levels of the multiindex IndexingError: Too many indexers was raised and is still raised. So would this be more proper?

Bug in :meth:`DataFrame.loc` and :meth:`Series.loc` where ``KeyError`` was not raised for a ``MultiIndex`` when the key was less than or equal to the number of levels in the :class:`MultiIndex` (:issue:`14885`).

ryanreh99 · 2019-04-24T14:33:32Z

made a change to the if statement as a KeyError wasn't raised for a particular condition. Added that test.

jreback · 2019-04-26T01:12:58Z

thanks @ryanreh99 very nice

ryanreh99 · 2019-04-26T08:29:57Z

@jreback thanks for all the help :D

ryanreh99 added 2 commits April 19, 2019 17:52

'BUG14885'

1cb75f9

Added KeyError Exception for MultiIndexes

ff3a81f

gfyoung added the Error Reporting Incorrect or improved errors from pandas label Apr 20, 2019

added KeyError and Exception blocks

0369704

ryanreh99 force-pushed the my-first-branch branch from 1800e1b to 0369704 Compare April 20, 2019 10:40

removed unused import statement

2fdacb5

jreback requested changes Apr 20, 2019

View reviewed changes

pandas/core/indexing.py Outdated Show resolved Hide resolved

pandas/core/indexing.py Outdated Show resolved Hide resolved

shifted KeyError check position

2c1b85b

jreback requested changes Apr 20, 2019

View reviewed changes

pandas/core/indexing.py Outdated Show resolved Hide resolved

pandas/core/indexing.py Show resolved Hide resolved

pandas/core/indexes/base.py Outdated Show resolved Hide resolved

added tests and fixed if statement

0f85550

ryanreh99 force-pushed the my-first-branch branch from b2c6375 to 0f85550 Compare April 20, 2019 21:13

ryanreh99 added 2 commits April 21, 2019 03:12

undo testcase change

51a1a3c

import statements - linting

0ee36cd

jreback requested changes Apr 21, 2019

View reviewed changes

pandas/tests/indexing/multiindex/test_loc.py Show resolved Hide resolved

jreback added this to the 0.25.0 milestone Apr 21, 2019

ryanreh99 added 3 commits April 22, 2019 02:16

Added whatsnew note and a DataFrame TestCase

5e06afe

Merge branch 'master' into my-first-branch

32404c5

removed blank line

467e1e7

ryanreh99 commented Apr 22, 2019

View reviewed changes

pandas/core/indexing.py Outdated Show resolved Hide resolved

ryanreh99 force-pushed the my-first-branch branch from ec751dc to 467e1e7 Compare April 22, 2019 05:47

ryanreh99 added 3 commits April 22, 2019 11:31

created new test_function

c7ce861

edited whats new

b6ede73

add full stop

ac544af

jreback requested changes Apr 23, 2019

View reviewed changes

pandas/core/indexing.py Outdated Show resolved Hide resolved

pandas/tests/indexing/multiindex/test_loc.py Show resolved Hide resolved

minor changes

de63fbe

jreback requested changes Apr 24, 2019

View reviewed changes

ryanreh99 added 2 commits April 24, 2019 19:35

more fixes

b95ae88

typo

2309e14

jreback approved these changes Apr 26, 2019

View reviewed changes

jreback merged commit e464a88 into pandas-dev:master Apr 26, 2019

ryanreh99 deleted the my-first-branch branch April 26, 2019 08:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BUG: Raise KeyError when indexing a Series with MultiIndex #26155

BUG: Raise KeyError when indexing a Series with MultiIndex #26155

ryanreh99 commented Apr 20, 2019 •

edited

pep8speaks commented Apr 20, 2019 •

edited

codecov bot commented Apr 20, 2019

codecov bot commented Apr 20, 2019 •

edited

jreback left a comment

jreback left a comment

jreback left a comment

ryanreh99 commented Apr 23, 2019

jreback Apr 24, 2019

ryanreh99 Apr 24, 2019

ryanreh99 commented Apr 24, 2019 •

edited

jreback commented Apr 26, 2019

ryanreh99 commented Apr 26, 2019

BUG: Raise KeyError when indexing a Series with MultiIndex #26155

BUG: Raise KeyError when indexing a Series with MultiIndex #26155

Conversation

ryanreh99 commented Apr 20, 2019 • edited

pep8speaks commented Apr 20, 2019 • edited

Comment last updated at 2019-04-24 14:32:03 UTC

codecov bot commented Apr 20, 2019

Codecov Report

codecov bot commented Apr 20, 2019 • edited

Codecov Report

jreback left a comment

Choose a reason for hiding this comment

jreback left a comment

Choose a reason for hiding this comment

jreback left a comment

Choose a reason for hiding this comment

ryanreh99 commented Apr 23, 2019

jreback Apr 24, 2019

Choose a reason for hiding this comment

ryanreh99 Apr 24, 2019

Choose a reason for hiding this comment

ryanreh99 commented Apr 24, 2019 • edited

jreback commented Apr 26, 2019

ryanreh99 commented Apr 26, 2019

ryanreh99 commented Apr 20, 2019 •

edited

pep8speaks commented Apr 20, 2019 •

edited

codecov bot commented Apr 20, 2019 •

edited

ryanreh99 commented Apr 24, 2019 •

edited