Remove Panel References #26287
Remove Panel References #26287
Conversation
| @@ -288,20 +288,7 @@ def validate_take_with_convert(convert, args, kwargs): | |||
|
|
|||
|
|
|||
| def validate_transpose_for_generic(inst, kwargs): | |||
| try: | |||
There was a problem hiding this comment.
This previously was only modifying the exception message for Panel objects before raising again, so I simplified to just remove the try...except altogether and let it raise as is
There was a problem hiding this comment.
If it’s a one liner now, Is this still needed as a separate function?
There was a problem hiding this comment.
Yea could probably just call this directly now; I'll give it a look tonight and repush
| # TODO: Raise NotImplementedError or change note in extending.rst | ||
| from pandas.core.panel import Panel | ||
| return Panel | ||
| raise NotImplementedError("Not supported for DataFrames!") |
There was a problem hiding this comment.
The TODO mentions changing the docs extending.rst but that looks to have already been done
pandas/core/generic.py
Outdated
| @@ -4091,8 +4090,7 @@ def sort_values(self, by=None, axis=0, ascending=True, inplace=False, | |||
| 0 A 2 0 | |||
| 1 A 1 1 | |||
| """ | |||
| raise NotImplementedError("sort_values has not been implemented " | |||
| "on Panel or Panel4D objects.") | |||
| raise NotImplementedError("sort_values has not been implemented.") | |||
There was a problem hiding this comment.
Since this is now never hit, should this be AbstractMethodError?
There was a problem hiding this comment.
Yea I think could go for that too
Codecov Report
@@ Coverage Diff @@
## master #26287 +/- ##
==========================================
+ Coverage 91.98% 92.02% +0.04%
==========================================
Files 175 175
Lines 52374 52301 -73
==========================================
- Hits 48178 48132 -46
+ Misses 4196 4169 -27
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26287 +/- ##
==========================================
+ Coverage 91.99% 92.03% +0.04%
==========================================
Files 175 175
Lines 52373 52294 -79
==========================================
- Hits 48178 48128 -50
+ Misses 4195 4166 -29
Continue to review full report at Codecov.
|
|
an you merge master and some checks are failing |
|
thanks @WillAyd love deleting code! |
|
https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=11204 is this because of this PR? |
|
Yea think so. I'll push a PR soon to correct |
progress towards #25632