CLN;: remove compat.lzip #26311
Merged
CLN;: remove compat.lzip #26311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #26311 +/- ##
==========================================
- Coverage 92.04% 92.03% -0.01%
==========================================
Files 175 175
Lines 52302 52292 -10
==========================================
- Hits 48141 48127 -14
- Misses 4161 4165 +4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26311 +/- ##
==========================================
- Coverage 92.04% 92.03% -0.01%
==========================================
Files 175 175
Lines 52302 52292 -10
==========================================
- Hits 48142 48128 -14
- Misses 4160 4164 +4
Continue to review full report at Codecov.
|
|
The failures are unrelated to this PR. (They are caused by #26287). |
|
If you merge master should fix CI issues
…Sent from my iPhone
On May 7, 2019, at 11:30 AM, topper-123 ***@***.***> wrote:
The failures are unrelated to this PR. (They are caused by #26287).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
topper-123
force-pushed
the
remove_compat.lzip
branch
from
bacd6cf
to
2ef50ae
Compare
jschendel
reviewed
May 7, 2019
pandas/core/generic.py
Outdated
| @@ -6502,7 +6502,7 @@ def replace(self, to_replace=None, value=None, inplace=False, limit=None, | |||
| regex = True | |||
|
|
|||
| items = list(to_replace.items()) | |||
| keys, values = lzip(*items) or ([], []) | |||
| keys, values = zip(*items) if len(items) else ([], []) | |||
There was a problem hiding this comment.
since items is a list I think you can modify the ternary to be zip(*items) if items else ([], [])
topper-123
force-pushed
the
remove_compat.lzip
branch
from
2ef50ae
to
bc464d8
Compare
topper-123
force-pushed
the
remove_compat.lzip
branch
from
bc464d8
to
792d3e0
Compare
|
Thanks @topper-123 ! Keep them coming! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removal of
compat.lzipfrom the code base.