Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: tests for needs-test issues #30222

Merged
merged 4 commits into from
Dec 12, 2019
Merged

TST: tests for needs-test issues #30222

merged 4 commits into from
Dec 12, 2019

Conversation

jbrockmendel
Copy link
Member

@gfyoung gfyoung added the Testing pandas testing functions or related to the test suite label Dec 12, 2019
@jreback jreback added this to the 1.0 milestone Dec 12, 2019
jreback
jreback reviewed Dec 12, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. couple of comments, ping on green.

pandas/tests/frame/test_constructors.py
@@ -1726,10 +1726,16 @@ def test_constructor_with_datetimes(self):
tm.assert_frame_equal(df, expected)

def test_constructor_datetimes_with_nulls(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can parameterize (later ok too)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbrockmendel : do you plan on addressing this here or later?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

later

@jbrockmendel
Copy link
Member Author

ping

@WillAyd WillAyd merged commit 53b90d3 into pandas-dev:master Dec 12, 2019
@WillAyd
Copy link
Member

WillAyd commented Dec 12, 2019

Thanks @jbrockmendel great work on this

@jbrockmendel jbrockmendel deleted the tst-needs branch December 12, 2019 21:06
@jreback
Copy link
Contributor

jreback commented Dec 12, 2019

thanks @jbrockmendel if you can parameterize as indicated would be great

jbrockmendel added a commit to jbrockmendel/pandas that referenced this pull request Dec 13, 2019
@jbrockmendel
requested paramertization from pandas-dev#30222
80d32e1
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jbrockmendel @proost
TST: tests for needs-test issues (pandas-dev#30222)
bbf96df
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jbrockmendel @proost
TST: tests for needs-test issues (pandas-dev#30222)
33a6f7e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

@gfyoung gfyoung gfyoung left review comments

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.0.0
4 participants
@jbrockmendel @WillAyd @jreback @gfyoung