Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST:Disallow bare pytest raises issue 30999 #31138

Merged
merged 9 commits into from
Jan 23, 2020
Merged

TST:Disallow bare pytest raises issue 30999 #31138

merged 9 commits into from
Jan 23, 2020

Conversation

shubchat
Copy link
Contributor

@shubchat shubchat commented Jan 19, 2020 •
edited
Loading

This pull request is to add appropriate match arguments to bare pytest.raises listed in #30999 Comment

@pep8speaks
Copy link

pep8speaks commented Jan 19, 2020 •
edited
Loading

Hello @shubchat! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-01-21 19:45:51 UTC

@jreback jreback added the Testing pandas testing functions or related to the test suite label Jan 20, 2020
@jorisvandenbossche jorisvandenbossche merged commit 7b9ebb0 into pandas-dev:master Jan 23, 2020
@jorisvandenbossche
Copy link
Member

Thanks @shubchat !

@gfyoung gfyoung added this to the 1.1 milestone Jan 23, 2020
@shubchat
Copy link
Contributor Author

Thanks @shubchat !

My pleasure @jorisvandenbossche

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

@ShaharNaveh ShaharNaveh ShaharNaveh approved these changes

@datapythonista datapythonista Awaiting requested review from datapythonista

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
6 participants
@shubchat @pep8speaks @jorisvandenbossche @ShaharNaveh @jreback @gfyoung