Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: GroupBy(..., as_index=True).agg() drops index #33098

Merged
merged 10 commits into from
Jun 15, 2020

Conversation

phofl
Copy link
Member

@phofl phofl commented Mar 28, 2020

While searching for related issue for my other pull request, I found that this issue must have been fixed with another commit in the past (don't know when this issue was fixed).

I added a test to ensure that this error won't know occur in the future.

@phofl phofl changed the title Bug 28641 add tests TEST: Add test for #28641 to ensure that error does not occur again Mar 28, 2020
@jreback jreback added Groupby Testing pandas testing functions or related to the test suite labels Mar 31, 2020
@jreback jreback added this to the 1.1 milestone Mar 31, 2020
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, a couple of comments, ping on green.

pandas/tests/groupby/test_categorical.py Outdated Show resolved Hide resolved
pandas/tests/groupby/aggregate/test_aggregate.py Outdated Show resolved Hide resolved
pandas/tests/groupby/aggregate/test_aggregate.py Outdated Show resolved Hide resolved
@alimcmaster1
Copy link
Member

Mind merging master? Failing test should be fixed

…641_add_test

� Conflicts:
�	pandas/tests/groupby/test_categorical.py
@phofl
Copy link
Member Author

phofl commented Apr 12, 2020

Merge master

Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phofl test failure unrelated. @jreback

@jreback jreback changed the title TEST: Add test for #28641 to ensure that error does not occur again TST: GroupBy(..., as_index=True).agg() drops index Jun 14, 2020
@jreback
Copy link
Contributor

jreback commented Jun 14, 2020

looks fine, can you merge master and ping on green.

@jreback jreback merged commit 4628665 into pandas-dev:master Jun 15, 2020
@jreback
Copy link
Contributor

jreback commented Jun 15, 2020

thanks @phofl

@phofl phofl deleted the BUG_28641_add_tests branch June 16, 2020 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Groupby Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GroupBy(..., as_index=True).agg() drops index when
5 participants