Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF: RelativeDeltaOffset.apply_index operate on ndarray #34613

Merged
merged 1 commit into from
Jun 8, 2020
Merged

REF: RelativeDeltaOffset.apply_index operate on ndarray #34613

merged 1 commit into from
Jun 8, 2020

Conversation

jbrockmendel
Copy link
Member

No description provided.

@jreback jreback added the Frequency DateOffsets label Jun 8, 2020
jreback
jreback requested changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this exercised in any tests?

@jbrockmendel
Copy link
Member Author

is this exercised in any tests?

Based on a quick check, looks like we have coverage for everything besides L1067

@jreback jreback added this to the 1.1 milestone Jun 8, 2020
@jreback
Copy link
Contributor

jreback commented Jun 8, 2020

is this exercised in any tests?

Based on a quick check, looks like we have coverage for everything besides L1067

kk if you want to add here or followon ok

@jbrockmendel
Copy link
Member Author

kk if you want to add here or followon ok

lets do for follow-on. there are a few more of these coming up

@jreback jreback merged commit ff75954 into pandas-dev:master Jun 8, 2020
@jbrockmendel jbrockmendel deleted the ref-apply_index-rdoffset branch June 8, 2020 16:23
@jorisvandenbossche
Copy link
Member

This is an API change?

@jbrockmendel
Copy link
Member Author

This is an API change?

No, apply_index_wraps already made it return an ndarray

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Frequency DateOffsets
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @jorisvandenbossche