Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: complement the documentation for pandas.DataFrame.agg #35912 #35941

Conversation

onshek
Copy link
Contributor

@onshek onshek commented Aug 28, 2020

Screenshot 2020-08-28 at 11 59 23

@pep8speaks
Copy link

pep8speaks commented Aug 28, 2020

Hello @onshek! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-08-29 07:56:56 UTC

reformat the documentation according to PEP  8
reformat the documentation according to PEP 8
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @onshek !

@charlesdong1991 charlesdong1991 added this to the 1.2 milestone Aug 28, 2020
@onshek onshek closed this Aug 29, 2020
@onshek onshek reopened this Aug 29, 2020
@onshek
Copy link
Contributor Author

onshek commented Aug 29, 2020

Sorry for closing it by mistake :)

@onshek
Copy link
Contributor Author

onshek commented Aug 30, 2020

Can anyone help me to figure out why two new checks failed here (This PR passed all 15/15 checks two days ago and I didn't make new changes)? Thanks! @MarcoGorelli @charlesdong1991 @rhshadrach

@MarcoGorelli
Copy link
Member

Can anyone help me to figure out why two new checks failed here (This PR passed all 15/15 checks two days ago and I didn't make new changes)? Thanks! @MarcoGorelli @charlesdong1991 @rhshadrach

Failures are unrelated, if you merge master and push again I'd expect them to be fixed

@onshek
Copy link
Contributor Author

onshek commented Aug 31, 2020

Can anyone help me to figure out why two new checks failed here (This PR passed all 15/15 checks two days ago and I didn't make new changes)? Thanks! @MarcoGorelli @charlesdong1991 @rhshadrach

Failures are unrelated, if you merge master and push again I'd expect them to be fixed

Got it, thanks!

@mroeschke mroeschke merged commit 2fd8021 into pandas-dev:master Aug 31, 2020
@mroeschke
Copy link
Member

Thanks @onshek. The CI failure is unrelated


============================= test session starts ==============================
platform linux -- Python 3.8.5, pytest-6.0.1, py-1.9.0, pluggy-0.13.1
rootdir: /home/vsts/work/1/s, configfile: setup.cfg, testpaths: pandas
plugins: hypothesis-5.28.0, forked-1.2.0, asyncio-0.12.0, xdist-2.1.0, azurepipelines-0.8.0
gw0 I / gw1 I
gw0 [76009] / gw1 [76009]

##[error]1 test(s) failed, 76009 test(s) collected.
Skipping uploading of coverage data.

=================================== FAILURES ===================================
_____________________ TestIndex.test_tab_complete_warning ______________________

jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this pull request Aug 31, 2020
…#35912 (pandas-dev#35941)

* DOC: complement the documentation for pandas.DataFrame.agg

* DOC: complement the documentation for pandas.DataFrame.agg

reformat the documentation according to PEP  8

* DOC: complement the documentation for pandas.DataFrame.agg

reformat the documentation according to PEP 8
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
…#35912 (pandas-dev#35941)

* DOC: complement the documentation for pandas.DataFrame.agg

* DOC: complement the documentation for pandas.DataFrame.agg

reformat the documentation according to PEP  8

* DOC: complement the documentation for pandas.DataFrame.agg

reformat the documentation according to PEP 8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Aggregate and rename is undocumented
5 participants