Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: remove unnecessary _validate_foo methods #37106

Merged
merged 49 commits into from
Oct 14, 2020
Merged

CLN: remove unnecessary _validate_foo methods #37106

merged 49 commits into from
Oct 14, 2020

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

since DatetimeLike and Categorical no longer special-case these, we can inline them.

jbrockmendel and others added 30 commits September 25, 2020 19:45
@jbrockmendel
CLN: dont special-case DatetimeArray indexing
665a522
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into dt…
36aa013 
…like-no-slice
@jbrockmendel
use parent class _validate_getitem_key
bdea70b
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into dt…
8c1acad 
…like-no-slice
@jbrockmendel
test, whatsnew
42e8e15
@karasinski @jbrockmendel
DOC: update code style for development doc and user guide pandas-dev#…
b80fcd8 
…36777 (pandas-dev#36821)
@karasinski @jbrockmendel
DOC: update code style for user guide for pandas-dev#36777 (pandas-de…
f3125ab 
…v#36823)
@PrayagS @jbrockmendel
DOC: use black to fix code style in doc pandas-dev#36777 (pandas-dev#…
de32fc7 
…36824)
@erfannariman @jbrockmendel
CI: silence codecov for unrelated lines (pandas-dev#36600)
f41ce46
@erfannariman @jbrockmendel
DOC: reformat doc groupby.rst (pandas-dev#36831)
c5c0aad
@fokoid @jbrockmendel
TST: GH23452 test reorder_categories() on categorical index (pandas-d…
0071389 
…ev#36648)
@lrjball @jbrockmendel
Typo fix (pandas-dev#36844)
b9be7ba 
Noticed a minor typo when using the docs
@ivanovmg @jbrockmendel
CLN: private funcs in concat.py (pandas-dev#36726)
b55d51a 
* REF: extract func _select_upcast_cls_from_dtype

* REF: extract function _get_upcast_classes

* CLN: rename g -> common_dtype

* TYP: type extracted functions

* DOC: add docstrings to extracted methods

* TYP: cast instead of ignoring mypy error

* CLN: import SparseDtype only for type checking
@jbrockmendel @jreback
ENH: match stdlib behavior for datetimelike comparisons (pandas-dev#3…
74b7b41 
…6647)

* ENH: match stdlib behavior for datetimelike comparisons

* update test

Co-authored-by: Jeff Reback <jeff@reback.net>
@meghanacosmos @jbrockmendel
doc/source/ecosystem.rst (pandas-dev#36856)
9d2399f
@jbrockmendel
DOC: black enhancingperf.rst and 10min.rst code style (pandas-dev#36849)
f6d3dfc
@LeviMatus @jbrockmendel
DOC: normalize usage of word "pandas" (pandas-dev#36845)
198af6a
@simonjayhawkins @jbrockmendel
TYP: update setup.cfg (pandas-dev#36854)
54f270c
@dsaxton @jbrockmendel
CI: Update error message for np_dev (pandas-dev#36864)
7587c94 
* CI: Update error message for np_dev

* Comma

* Fix
@maria-ilie @jbrockmendel
DOC: ran blacken docs tool and checked output to improve formatting p…
e5dcd98 
…andas-dev#36777 (pandas-dev#36802)
@jbrockmendel
CLN: Remove the duplicate configuration of flake8-rst in setup.cfg (p…
cd82086 
…andas-dev#36877)
@Tazminia @jbrockmendel
upgrade flake8 to 3.8.4 (pandas-dev#36882)
0b5f2dd
@meghanacosmos @jbrockmendel
DOC: doc/source/whatsnew (pandas-dev#36857)
185d2ea
@simonjayhawkins @jbrockmendel
TYP: check_untyped_defs core.arrays.base (pandas-dev#36885)
fa93585
@simonjayhawkins @jbrockmendel
TYP: check_untyped_defs compat.pickle_compat (pandas-dev#36884)
9216b94
@mroeschke @jbrockmendel
PERF: Improve RollingGroupby.count (pandas-dev#36872)
125b3e4
@simonjayhawkins @jbrockmendel
DOC: 1.1.3 release date (pandas-dev#36887)
fa0f216
@avinashpancham @jbrockmendel
Add asv benchmarks for select_dtypes (pandas-dev#36839)
30cc26c
@dsaxton @jbrockmendel
DOC: Start v1.1.4 release notes (pandas-dev#36689)
c77ce8b
@OlivierLuG @jbrockmendel
TST: Period with Timestamp overflow (pandas-dev#34755)
a403610 
* #TST pandas-dev#13346 added tests

* TST pandas-dev#13346 taken review into account

* Added tests for pandas-dev#13346 - with review
dsaxton and others added 19 commits October 6, 2020 10:36
@dsaxton @jbrockmendel
CI: Show ipython directive errors (pandas-dev#36863)
fa8e066
@jbrockmendel
Standardize cast_str behavior in all datetimelike fill_value validato…
ec2b663 
…rs (pandas-dev#36746)

* Standardize cast_str behavior in all datetimelike fill_value validators

* CLN: remove cast_str kwarg
@jbrockmendel
CLN: value -> key (pandas-dev#36905)
6c60603
@jbrockmendel
CLN: standardize fixture usage in datetimelike array tests (pandas-de…
de35fe2 
…v#36902)
@jbrockmendel
DEPR: Index.ravel returning an ndarray (pandas-dev#36900)
605cc0b
@jbrockmendel
REF: collect reduction tests (pandas-dev#36901)
6e34063
@topper-123 @jreback @jbrockmendel
PERF: Index._shallow_copy shares _cache with copies of self (pandas-d…
2847337 
…ev#36840)

* PERF: Index.equals when comparing to copies of self

* refactor _shallow_copy, add GH number

* PERF: share _cache, don't share _id

* rename tests

* fix memory usage test

Co-authored-by: Jeff Reback <jeff@reback.net>
@jbrockmendel
checkout upstream versions
265ffb0
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
0553a99 
…f-share-7
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
c956081 
…f-share-7
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
9923ac3 
…f-share-7
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
92e6853 
…f-share-7
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
7d13382 
…f-share-7
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
b4a2714 
…f-share-7
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
4c59814 
…f-share-7
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
af61fe8 
…f-share-7
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
d3dad4c 
…f-share-7
@jbrockmendel
CLN: remove unnecessary validate_ methdos
5b80f24
@jbrockmendel
dummy commit to force CI
80561bc
@jreback jreback added Clean Indexing Related to indexing on series/frames, not to indexes themselves labels Oct 14, 2020
@jreback jreback added this to the 1.2 milestone Oct 14, 2020
@jreback jreback merged commit 401d7a1 into pandas-dev:master Oct 14, 2020
@jreback
Copy link
Contributor

jreback commented Oct 14, 2020

i guess the windows failures are spurious

@jbrockmendel jbrockmendel deleted the ref-share-7 branch October 14, 2020 14:42
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Oct 26, 2020
@jbrockmendel @JulianWgs
CLN: remove unnecessary _validate_foo methods (pandas-dev#37106)
bbc0030
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@jbrockmendel
CLN: remove unnecessary _validate_foo methods (pandas-dev#37106)
9d9dad5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Clean Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

None yet