-
-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLN/REF: Refactor min_periods calculation in rolling #37156
CLN/REF: Refactor min_periods calculation in rolling #37156
Conversation
@@ -498,7 +498,7 @@ def test_rolling_count_default_min_periods_with_null_values(constructor): | |||
({"A": [2, 3], "B": [5, 6]}, [1, 2]), | |||
], | |||
2, | |||
3, | |||
2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These test changes are related to the whatsnew entry: This should not have passed previously.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what whatsnew entry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, thought I added it is previously. Should be there now.
cool. was there a referenced issue? |
No, just discovered independently |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff