ENH: implement matching warning message #37263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/_testing.py
Outdated
| @@ -2550,6 +2551,7 @@ def assert_produces_warning( | |||
| filter_level="always", | |||
| check_stacklevel=True, | |||
| raise_on_extra_warnings=True, | |||
| match=None, | |||
There was a problem hiding this comment.
Annotated, but presumably the code became slightly less pythonic. Sorry for that.
| ], | ||
| ) | ||
| def category(request): | ||
| """Return unique warning. |
jreback
reviewed
Oct 20, 2020
There was a problem hiding this comment.
comment, but ok to merge after @jbrockmendel doc-string comments.
pandas/_testing.py
Outdated
| if raise_on_extra_warnings and extra_warnings: | ||
| raise AssertionError( | ||
| f"Caused unexpected warning(s): {repr(extra_warnings)}" | ||
| ) | ||
|
|
||
|
|
||
| def _assert_raised_with_correct_stacklevel(actual_warning): |
There was a problem hiding this comment.
Annotated. IMHO, the type warnings.WarningMessage, although correct, has a confusing name for warning instance.
| @@ -0,0 +1,138 @@ | |||
| """" | |||
| Test module for testing ``pandas._testing.assert_produces_warning``. | |||
| """ | |||
There was a problem hiding this comment.
There is already a file with tests for this, in tests/util/test_assert_produces_warning.py, can you move this there?
There was a problem hiding this comment.
Oh, I completely missed it. I moved tests as requested.
|
thanks @ivanovmg very nice |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Oct 26, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffImplement matching warning message.
New kwarg
matchinassert_produces_warning.