Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: add searchsorted examples #36411 #37370

Merged
merged 4 commits into from
Oct 25, 2020
Merged

DOC: add searchsorted examples #36411 #37370

merged 4 commits into from
Oct 25, 2020

Conversation

Mikhaylov-yv
Copy link
Contributor

@Mikhaylov-yv Mikhaylov-yv commented Oct 23, 2020

DOC: add searchsorted examples #36411

@pep8speaks
Copy link

pep8speaks commented Oct 23, 2020

Hello @Mikhaylov-yv! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-10-25 16:50:32 UTC

Copy link
Member

@arw2019 arw2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mikhaylov-yv for the PR!

A comment

2 2020-10-23
dtype: datetime64[ns]

>>> ser.searchsorted('3/14/2000')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry if i'm being slow but shouldn't this return 0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are absolutely right. thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also need to use the same dates in the constructed series and the output
(that's why CI is red atm. Once these are fixed I think you're ready to go)

@mroeschke mroeschke added the Docs label Oct 25, 2020
@mroeschke mroeschke added this to the 1.2 milestone Oct 25, 2020
@mroeschke mroeschke merged commit 50c8c69 into pandas-dev:master Oct 25, 2020
@mroeschke
Copy link
Member

Thanks @Mikhaylov-yv

JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Oct 26, 2020
* DOC: add searchsorted examples

* Update base.py

* corrected values

* Update base.py
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
* DOC: add searchsorted examples

* Update base.py

* corrected values

* Update base.py
@Mikhaylov-yv Mikhaylov-yv deleted the DOC#36411 branch November 5, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants