Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: helper to ensure column indexer is iterable #37475

Merged

Conversation

jbrockmendel
Copy link
Member

Helper method separated out from upcoming PR to split _setitem_with_indexer into more manageable pieces, which in turn is part of fixing a goes-through-two-separate-paths problem.

@jreback jreback added the Indexing Related to indexing on series/frames, not to indexes themselves label Oct 29, 2020
@jreback jreback added this to the 1.2 milestone Oct 29, 2020
@@ -1900,6 +1897,20 @@ def _setitem_with_indexer_missing(self, indexer, value):
self.obj._mgr = self.obj.append(value)._mgr
self.obj._maybe_update_cacher(clear=True)

def _ensure_iterable_column_indexer(self, column_indexer):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typ at some point

@jreback jreback merged commit 2db4e34 into pandas-dev:master Oct 29, 2020
@jbrockmendel jbrockmendel deleted the ref-ensure_iterable_column_indexer branch October 29, 2020 02:01
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
ukarroum pushed a commit to ukarroum/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants