-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: 32 bit maybe_indices_to_slice #37473
Conversation
hmm you are backing this to fix the 32-bit tests? does this have a perf hit? |
Not sure yet, still trying to get this passing |
got some more troubleshooting to do, but in the interim, some greenish: #37365, #37402, #37449, #37451, #37456, #37470, #37472, #37475 The deluge is going to slow to a crawl since the next task on my list is a doozy: figuring out why the categorical validators all behave slightly differently. |
alright, got the 32bit working |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can u run asvs
i can start them running overnight. this should be totally neutral on 64bit since np.intp is an alias for np.int64 |
to be reverted after pandas-dev/pandas#37473 backported
forgot to run asvs overnight, just started them now. |
ran with
|
@jreback if this is ready to merge will backport, otherwise can just skip failing 32 bit test on MacPython. |
thanks @jbrockmendel |
@meeseeksdev backport 1.1.x |
Co-authored-by: jbrockmendel <jbrockmendel@gmail.com>
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff