Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: 32 bit maybe_indices_to_slice #37473

Merged
merged 8 commits into from
Oct 29, 2020
Merged

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@simonjayhawkins simonjayhawkins added this to the 1.1.4 milestone Oct 28, 2020
@simonjayhawkins simonjayhawkins added the 32bit 32-bit systems label Oct 28, 2020
@jreback
Copy link
Contributor

jreback commented Oct 28, 2020

hmm you are backing this to fix the 32-bit tests? does this have a perf hit?

@jbrockmendel
Copy link
Member Author

Not sure yet, still trying to get this passing

@jbrockmendel
Copy link
Member Author

got some more troubleshooting to do, but in the interim, some greenish: #37365, #37402, #37449, #37451, #37456, #37470, #37472, #37475
and green but less trivial #37425, #37436, #37423, #37425, #37179, #37164, #34683

The deluge is going to slow to a crawl since the next task on my list is a doozy: figuring out why the categorical validators all behave slightly differently.

@jbrockmendel
Copy link
Member Author

alright, got the 32bit working

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can u run asvs

@jbrockmendel
Copy link
Member Author

can u run asvs

i can start them running overnight. this should be totally neutral on 64bit since np.intp is an alias for np.int64

@simonjayhawkins simonjayhawkins mentioned this pull request Oct 29, 2020
simonjayhawkins added a commit to simonjayhawkins/pandas-wheels that referenced this pull request Oct 29, 2020
@jbrockmendel
Copy link
Member Author

forgot to run asvs overnight, just started them now.

@jbrockmendel
Copy link
Member Author

ran with -b index

BENCHMARKS NOT SIGNIFICANTLY CHANGED.

@simonjayhawkins
Copy link
Member

@jreback if this is ready to merge will backport, otherwise can just skip failing 32 bit test on MacPython.

@jreback jreback merged commit 2414c75 into pandas-dev:master Oct 29, 2020
@jreback
Copy link
Contributor

jreback commented Oct 29, 2020

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the ci-32 branch October 29, 2020 21:48
@simonjayhawkins
Copy link
Member

@meeseeksdev backport 1.1.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Oct 29, 2020
simonjayhawkins pushed a commit that referenced this pull request Oct 30, 2020
Co-authored-by: jbrockmendel <jbrockmendel@gmail.com>
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
ukarroum pushed a commit to ukarroum/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
32bit 32-bit systems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants